Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: net/base/sdch_manager_unittest.cc

Issue 414563002: Added stats on why blacklisted requests were blacklisted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/sdch_manager_unittest.cc
diff --git a/net/base/sdch_manager_unittest.cc b/net/base/sdch_manager_unittest.cc
index 87b01f4f7ae574293fad5dd9f8cfd30033a1a563..fbfff9e20ce1ae50378529668cccb208a171d689 100644
--- a/net/base/sdch_manager_unittest.cc
+++ b/net/base/sdch_manager_unittest.cc
@@ -65,11 +65,11 @@ TEST_F(SdchManagerTest, DomainBlacklisting) {
GURL test_url("http://www.test.com");
GURL google_url("http://www.google.com");
- sdch_manager()->BlacklistDomain(test_url);
+ sdch_manager()->BlacklistDomain(test_url, SdchManager::MIN_PROBLEM_CODE);
EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(test_url));
EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(google_url));
- sdch_manager()->BlacklistDomain(google_url);
+ sdch_manager()->BlacklistDomain(google_url, SdchManager::MIN_PROBLEM_CODE);
EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(google_url));
}
@@ -79,7 +79,7 @@ TEST_F(SdchManagerTest, DomainBlacklistingCaseSensitivity) {
EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(test_url));
EXPECT_TRUE(sdch_manager()->IsInSupportedDomain(test2_url));
- sdch_manager()->BlacklistDomain(test_url);
+ sdch_manager()->BlacklistDomain(test_url, SdchManager::MIN_PROBLEM_CODE);
EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(test2_url));
}
@@ -98,7 +98,7 @@ TEST_F(SdchManagerTest, BlacklistingSingleBlacklist) {
std::string domain(gurl.host());
sdch_manager()->ClearBlacklistings();
- sdch_manager()->BlacklistDomain(gurl);
+ sdch_manager()->BlacklistDomain(gurl, SdchManager::MIN_PROBLEM_CODE);
EXPECT_EQ(sdch_manager()->BlackListDomainCount(domain), 1);
EXPECT_EQ(sdch_manager()->BlacklistDomainExponential(domain), 1);
@@ -115,7 +115,7 @@ TEST_F(SdchManagerTest, BlacklistingExponential) {
int exponential = 1;
for (int i = 1; i < 100; ++i) {
- sdch_manager()->BlacklistDomain(gurl);
+ sdch_manager()->BlacklistDomain(gurl, SdchManager::MIN_PROBLEM_CODE);
EXPECT_EQ(sdch_manager()->BlacklistDomainExponential(domain), exponential);
EXPECT_EQ(sdch_manager()->BlackListDomainCount(domain), exponential);
@@ -460,7 +460,8 @@ TEST_F(SdchManagerTest, ClearDictionaryData) {
&dictionary);
EXPECT_TRUE(dictionary);
- sdch_manager()->BlacklistDomain(GURL(blacklist_url));
+ sdch_manager()->BlacklistDomain(GURL(blacklist_url),
+ SdchManager::MIN_PROBLEM_CODE);
EXPECT_FALSE(sdch_manager()->IsInSupportedDomain(blacklist_url));
sdch_manager()->ClearData();

Powered by Google App Engine
This is Rietveld 408576698