Added stats on why blacklisted requests were blacklisted.

net/base/sdch_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Provides global database of differential decompression dictionaries for the
 // SDCH filter (processes sdch enconded content).
 
 // Exactly one instance of SdchManager is built, and all references are made
 // into that collection.
 //
@@ skipping 247 matching lines @@
 
   static bool secure_scheme_supported() { return g_secure_scheme_supported_; }
 
   // Briefly prevent further advertising of SDCH on this domain (if SDCH is
   // enabled). After enough calls to IsInSupportedDomain() the blacklisting
   // will be removed.  Additional blacklists take exponentially more calls
   // to IsInSupportedDomain() before the blacklisting is undone.
   // Used when filter errors are found from a given domain, but it is plausible
   // that the cause is temporary (such as application startup, where cached
   // entries are used, but a dictionary is not yet loaded).
-  void BlacklistDomain(const GURL& url);
+  void BlacklistDomain(const GURL& url, ProblemCodes blacklist_reason);
 
   // Used when SEVERE filter errors are found from a given domain, to prevent
   // further use of SDCH on that domain.
-  void BlacklistDomainForever(const GURL& url);
+  void BlacklistDomainForever(const GURL& url, ProblemCodes blacklist_reason);
 
   // Unit test only, this function resets enabling of sdch, and clears the
   // blacklist.
   void ClearBlacklistings();
 
   // Unit test only, this function resets the blacklisting count for a domain.
   void ClearDomainBlacklisting(const std::string& domain);
 
   // Unit test only: indicate how many more times a domain will be blacklisted.
   int BlackListDomainCount(const std::string& domain);
@@ skipping 47 matching lines @@
 
   // For Latency testing only, we need to know if we've succeeded in doing a
   // round trip before starting our comparative tests.  If ever we encounter
   // problems with SDCH, we opt-out of the test unless/until we perform a
   // complete SDCH decoding.
   bool AllowLatencyExperiment(const GURL& url) const;
 
   void SetAllowLatencyExperiment(const GURL& url, bool enable);
 
  private:
-  typedef std::map<std::string, int> DomainCounter;
+  struct BlacklistInfo {
+    int count;                   // # of times to refuse SDCH advertisement.
+    int exponential_count;       // Current exponential backoff ratchet.
+    ProblemCodes reason;         // Why domain was blacklisted.
+
+    BlacklistInfo()

[jar (doing other things), 2014/07/23 14:02:53]

nit: constuctor should be listed before members.

[Randy Smith (Not in Mondays), 2014/08/11 20:46:39]

Done.

+        : count(0),
+          exponential_count(0),
+          reason(MIN_PROBLEM_CODE) {}
+  };
+  typedef std::map<std::string, BlacklistInfo> DomainBlacklistInfo;
   typedef std::set<std::string> ExperimentSet;
 
   // A map of dictionaries info indexed by the hash that the server provides.
   typedef std::map<std::string, scoped_refptr<Dictionary> > DictionaryMap;
 
   // Support SDCH compression, by advertising in headers.
   static bool g_sdch_enabled_;
 
   // Support SDCH compression for HTTPS requests and responses. When supported,
   // HTTPS applicable dictionaries MUST have been acquired securely via HTTPS.
   static bool g_secure_scheme_supported_;
 
   // A simple implementation of a RFC 3548 "URL safe" base64 encoder.
   static void UrlSafeBase64Encode(const std::string& input,
                                   std::string* output);
   DictionaryMap dictionaries_;
 
   // An instance that can fetch a dictionary given a URL.
   scoped_ptr<SdchFetcher> fetcher_;
 
-  // List domains where decode failures have required disabling sdch, along with
-  // count of how many additonal uses should be blacklisted.
-  DomainCounter blacklisted_domains_;
-
-  // Support exponential backoff in number of domain accesses before
-  // blacklisting expires.
-  DomainCounter exponential_blacklist_count_;
+  // List domains where decode failures have required disabling sdch.
+  DomainBlacklistInfo blacklisted_domains_;
 
   // List of hostnames for which a latency experiment is allowed (because a
   // round trip test has recently passed).
   ExperimentSet allow_latency_experiment_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_MANAGER_H_