SkFontMgr for Android.

SkFontMgr for Android.

Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06

Committed: https://skia.googlesource.com/skia/+/8d84c995319dd4a82e4f2054bbd19f968c671ca6

[bungeman-skia, 2014-07-22 17:27:44]

Continuation of https://codereview.chromium.org/384503002/ .

[djsollen, 2014-07-22 18:18:29]

https://codereview.chromium.org/414483002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/414483002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:620: #          'SK_FONTHOST_DOES_NOT_USE_FONTMGR',
add me back!

https://codereview.chromium.org/414483002/diff/1/src/core/SkScalerContext.cpp
File src/core/SkScalerContext.cpp (right):

https://codereview.chromium.org/414483002/diff/1/src/core/SkScalerContext.cpp...
src/core/SkScalerContext.cpp:173: /*  Return the next context.
add this back!

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android.cpp
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:64: void onGetFontDescriptor(SkFontDescriptor*
desc, bool* serialize) const SK_OVERRIDE {
virtual?

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:73: // On Android, system fonts are installed on
the device; the XML catalogs
remove the comment

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:115: namespace {
remove namespace

[bungeman-skia, 2014-07-22 18:48:16]

https://codereview.chromium.org/414483002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/414483002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:620: #          'SK_FONTHOST_DOES_NOT_USE_FONTMGR',
On 2014/07/22 18:18:29, djsollen wrote:
> add me back!

Done.

https://codereview.chromium.org/414483002/diff/1/src/core/SkScalerContext.cpp
File src/core/SkScalerContext.cpp (right):

https://codereview.chromium.org/414483002/diff/1/src/core/SkScalerContext.cpp...
src/core/SkScalerContext.cpp:173: /*  Return the next context.
On 2014/07/22 18:18:29, djsollen wrote:
> add this back!

Done.

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android.cpp
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:64: void onGetFontDescriptor(SkFontDescriptor*
desc, bool* serialize) const SK_OVERRIDE {
On 2014/07/22 18:18:29, djsollen wrote:
> virtual?

Done.

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:73: // On Android, system fonts are installed on
the device; the XML catalogs
On 2014/07/22 18:18:29, djsollen wrote:
> remove the comment

Done.

https://codereview.chromium.org/414483002/diff/1/src/ports/SkFontMgr_android....
src/ports/SkFontMgr_android.cpp:115: namespace {
On 2014/07/22 18:18:29, djsollen wrote:
> remove namespace

Done.

[djsollen, 2014-07-22 18:52:11]

lgtm, now we just need to implement the top 2 methods in SkTypeface_android.h

[bungeman-skia, 2014-07-22 18:54:49]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2014-07-22 18:55:04]

On 2014/07/22 18:52:11, djsollen wrote:
> lgtm, now we just need to implement the top 2 methods in SkTypeface_android.h

Will work on this next.

[commit-bot: I haz the power, 2014-07-22 18:55:19]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/414483002/40001

[commit-bot: I haz the power, 2014-07-22 19:07:27]

Change committed as 4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06

[robertphillips, 2014-07-22 23:35:40]

A revert of this CL has been created in
https://codereview.chromium.org/408143010/ by robertphillips@google.com.

The reason for reverting is: Reverting to unblock DEPS roll..

[robertphillips, 2014-07-23 11:57:19]

Here is the log of one of the failing Chromium Android trybots:

http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...

In case of bitrot, here is the error:

obj/third_party/skia/src/core/skia.SkFontHost.o: in function
SkFontMgr::CreateDefault():../../third_party/skia/src/core/SkFontHost.cpp(.text._ZN9SkFontMgr13CreateDefaultEv+0x4):
error: undefined reference to 'SkFontMgr::Factory()'

[bungeman-skia, 2014-07-24 14:52:16]

On 2014/07/23 11:57:19, robertphillips wrote:
> Here is the log of one of the failing Chromium Android trybots:
> 
>
http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...
> 
> In case of bitrot, here is the error:
> 
> obj/third_party/skia/src/core/skia.SkFontHost.o: in function
>
SkFontMgr::CreateDefault():../../third_party/skia/src/core/SkFontHost.cpp(.text._ZN9SkFontMgr13CreateDefaultEv+0x4):
> error: undefined reference to 'SkFontMgr::Factory()'

This change will require a manual roll, adding a file to Chromium. See
https://codereview.chromium.org/413743003/ .

[bungeman-skia, 2014-07-24 14:52:42]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-07-24 14:53:41]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/414483002/60001

[commit-bot: I haz the power, 2014-07-24 15:05:19]

Change committed as 8d84c995319dd4a82e4f2054bbd19f968c671ca6