Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 414473002: Re-enable mobile memory tests. (Closed)

Created:
6 years, 5 months ago by Victor Starodub
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable mobile memory tests. BUG=370977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284854

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed unittest, fixed lint error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/mobile_memory.json View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Victor Starodub
The mentioned fix is in and the tests seem to work fine now.
6 years, 5 months ago (2014-07-22 17:29:11 UTC) #1
tonyg
https://codereview.chromium.org/414473002/diff/1/tools/perf/benchmarks/memory.py File tools/perf/benchmarks/memory.py (left): https://codereview.chromium.org/414473002/diff/1/tools/perf/benchmarks/memory.py#oldcode10 tools/perf/benchmarks/memory.py:10: @benchmark.Disabled('android') # crbug.com/370977 If this benchmark opens multiple tabs, ...
6 years, 5 months ago (2014-07-22 17:43:51 UTC) #2
Victor Starodub
https://codereview.chromium.org/414473002/diff/1/tools/perf/benchmarks/memory.py File tools/perf/benchmarks/memory.py (left): https://codereview.chromium.org/414473002/diff/1/tools/perf/benchmarks/memory.py#oldcode10 tools/perf/benchmarks/memory.py:10: @benchmark.Disabled('android') # crbug.com/370977 On 2014/07/22 17:43:51, tonyg wrote: > ...
6 years, 5 months ago (2014-07-22 18:35:34 UTC) #3
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 5 months ago (2014-07-22 18:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/414473002/1
6 years, 5 months ago (2014-07-22 18:37:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 00:21:19 UTC) #6
commit-bot: I haz the power
Change committed as 284854
6 years, 5 months ago (2014-07-23 06:08:55 UTC) #7
tonyg
6 years, 5 months ago (2014-07-24 01:09:51 UTC) #8
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/413093003/ by tonyg@chromium.org.

The reason for reverting is: Fails on multiple android bots. For example:

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/bu....

Powered by Google App Engine
This is Rietveld 408576698