Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 414453003: Simplify SelectorChecker's parentElement() function (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Simplify SelectorChecker's parentElement() function Simplify SelectorChecker's parentElement() function by merging two if conditions that end up returning the same result. This lets the compiler generate slightly more efficient code. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M Source/core/css/SelectorChecker.cpp View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
Diff on the generated assembly: http://pastebin.com/TZyaKQWn
6 years, 5 months ago (2014-07-22 17:55:23 UTC) #1
esprehn
On 2014/07/22 at 17:55:23, ch.dumez wrote: > Diff on the generated assembly: > http://pastebin.com/TZyaKQWn Thanks, ...
6 years, 4 months ago (2014-08-01 14:14:42 UTC) #2
esprehn
lgtm
6 years, 4 months ago (2014-08-01 14:14:46 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-01 14:24:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/414453003/1
6 years, 4 months ago (2014-08-01 14:24:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 14:28:46 UTC) #6
Message was sent while issue was closed.
Change committed as 179399

Powered by Google App Engine
This is Rietveld 408576698