Oilpan: Prepare to move ResourceLoader and ResourceLoaderSet to Oilpan heap.

Oilpan: Prepare to move ResourceLoader and ResourceLoaderSet to Oilpan heap.

Also, this CL adds missing ResourceLoaderSet factory.

BUG=393516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179120

[tkent, 2014-07-29 05:08:37]

Please review this.

[zerny-chromium, 2014-07-29 06:36:45]

lgtm

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/Resource.h:306: HashSet<Resource*>
m_resourcesWithPendingClients;
This set looks like it should be traced somehow now.

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceLoaderSet.h (right):

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/ResourceLoaderSet.h:39: class ResourceLoaderSet : public
NoBaseWillBeGarbageCollected<ResourceLoaderSet> {
Nit: FINAL

[tkent, 2014-07-29 08:38:43]

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/Resource.h:306: HashSet<Resource*>
m_resourcesWithPendingClients;
On 2014/07/29 06:36:45, zerny-chromium wrote:
> This set looks like it should be traced somehow now.

yeah, I'll work on it.

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceLoaderSet.h (right):

https://codereview.chromium.org/414423003/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/ResourceLoaderSet.h:39: class ResourceLoaderSet : public
NoBaseWillBeGarbageCollected<ResourceLoaderSet> {
On 2014/07/29 06:36:45, zerny-chromium wrote:
> Nit: FINAL

Done.

[tkent, 2014-07-29 08:38:47]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-29 08:39:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/414423003/40001

[commit-bot: I haz the power, 2014-07-29 09:47:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17490)

[haraken, 2014-07-29 10:30:17]

LGTM

https://codereview.chromium.org/414423003/diff/40001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceFetcher.h (right):

https://codereview.chromium.org/414423003/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.h:215: OwnPtr<ListHashSet<Resource*> >
m_preloads;

Consider using HeapListHashSet in a follow-up. (Actually I'm not sure why it's
safe to touch m_preloads in ResourceFetcher's destructor.)

https://codereview.chromium.org/414423003/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.h:220: typedef HashMap<Resource*,
RefPtr<ResourceTimingInfo> > ResourceTimingInfoMap;

Consider using HeapHashMap in a follow-up.

https://codereview.chromium.org/414423003/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.h:249: class ResourceCacheValidationSuppressor
{

Consider moving this to the heap in a follow-up.

[commit-bot: I haz the power, 2014-07-29 10:36:58]

Change committed as 179120