content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed few nits and new line issues. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 5caa21422090dda3c8d40ff1abb37c6dad6625c0..2ccffcce0f8f1daa3808aa37b6a5df52ddd48b50 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -136,6 +136,26 @@ import org.chromium.content_public.browser.WebContents;

nativeSelectWordAroundCaret(mNativeWebContentsAndroid);

}

+ @Override

+ public String getUrl() {

+ return nativeGetURL(mNativeWebContentsAndroid);

+ }

+ @Override

+ public boolean isIncognito() {

+ return nativeIsIncognito(mNativeWebContentsAndroid);

+ }

+ @Override

+ public void resumeResponseDeferredAtStart() {

+ nativeResumeResponseDeferredAtStart(mNativeWebContentsAndroid);

+ }

+ @Override

+ public void setHasPendingNavigationTransitionForTesting() {

+ nativeSetHasPendingNavigationTransitionForTesting(mNativeWebContentsAndroid);

+ }

private native String nativeGetTitle(long nativeWebContentsAndroid);

private native String nativeGetVisibleURL(long nativeWebContentsAndroid);

private native void nativeStop(long nativeWebContentsAndroid);

@@ -155,4 +175,9 @@ import org.chromium.content_public.browser.WebContents;

private native void nativeShowImeIfNeeded(long nativeWebContentsAndroid);

private native void nativeScrollFocusedEditableNodeIntoView(long nativeWebContentsAndroid);

private native void nativeSelectWordAroundCaret(long nativeWebContentsAndroid);

+ private native String nativeGetURL(long nativeWebContentsAndroid);

+ private native boolean nativeIsIncognito(long nativeWebContentsAndroid);

+ private native void nativeResumeResponseDeferredAtStart(long nativeWebContentsAndroid);

+ private native void nativeSetHasPendingNavigationTransitionForTesting(

+ long nativeWebContentsAndroid);

}