Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed setHasPendingNavigationTransitionForTesting from CVC. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content_public/browser/WebContents.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java
index adfcf9e5bfe8df8b68df4be4e0e9f3b479b1d5a6..a9035b7c0271d13e186230b30e9c5e9e33398b47 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java
@@ -9,8 +9,8 @@ import android.text.TextUtils;
import android.util.Pair;
import org.chromium.base.test.util.UrlUtils;
-import org.chromium.content.browser.ContentViewCore.NavigationTransitionDelegate;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
+import org.chromium.content_public.browser.NavigationTransitionDelegate;
import org.chromium.content_shell_apk.ContentShellActivity;
import org.chromium.content_shell_apk.ContentShellTestBase;
import org.chromium.net.test.util.TestWebServer;
@@ -110,11 +110,11 @@ public class TransitionTest extends ContentShellTestBase {
TestCallbackHelperContainer testCallbackHelperContainer =
new TestCallbackHelperContainer(contentViewCore);
- contentViewCore.setHasPendingNavigationTransitionForTesting();
+ contentViewCore.getWebContents().setHasPendingNavigationTransitionForTesting();
TestNavigationTransitionDelegate delegate = new TestNavigationTransitionDelegate(
contentViewCore,
true);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
loadUrl(contentViewCore, testCallbackHelperContainer, new LoadUrlParams(URL_1));
@@ -133,11 +133,11 @@ public class TransitionTest extends ContentShellTestBase {
TestCallbackHelperContainer testCallbackHelperContainer =
new TestCallbackHelperContainer(contentViewCore);
- contentViewCore.setHasPendingNavigationTransitionForTesting();
+ contentViewCore.getWebContents().setHasPendingNavigationTransitionForTesting();
TestNavigationTransitionDelegate delegate = new TestNavigationTransitionDelegate(
contentViewCore,
false);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
loadUrl(contentViewCore, testCallbackHelperContainer, new LoadUrlParams(URL_1));
@@ -158,7 +158,7 @@ public class TransitionTest extends ContentShellTestBase {
TestNavigationTransitionDelegate delegate = new TestNavigationTransitionDelegate(
contentViewCore,
false);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
loadUrl(contentViewCore, testCallbackHelperContainer, new LoadUrlParams(URL_1));
@@ -183,10 +183,10 @@ public class TransitionTest extends ContentShellTestBase {
ContentViewCore contentViewCore = activity.getActiveContentViewCore();
TestCallbackHelperContainer testCallbackHelperContainer =
new TestCallbackHelperContainer(contentViewCore);
- contentViewCore.setHasPendingNavigationTransitionForTesting();
+ contentViewCore.getWebContents().setHasPendingNavigationTransitionForTesting();
TestNavigationTransitionDelegate delegate =
new TestNavigationTransitionDelegate(contentViewCore, true);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
int currentCallCount = testCallbackHelperContainer
.getOnPageFinishedHelper().getCallCount();
@@ -235,10 +235,10 @@ public class TransitionTest extends ContentShellTestBase {
ContentViewCore contentViewCore = activity.getActiveContentViewCore();
TestCallbackHelperContainer testCallbackHelperContainer =
new TestCallbackHelperContainer(contentViewCore);
- contentViewCore.setHasPendingNavigationTransitionForTesting();
+ contentViewCore.getWebContents().setHasPendingNavigationTransitionForTesting();
TestNavigationTransitionDelegate delegate =
new TestNavigationTransitionDelegate(contentViewCore, true);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
int currentCallCount = testCallbackHelperContainer
.getOnPageFinishedHelper().getCallCount();
@@ -277,10 +277,10 @@ public class TransitionTest extends ContentShellTestBase {
ContentViewCore contentViewCore = activity.getActiveContentViewCore();
TestCallbackHelperContainer testCallbackHelperContainer =
new TestCallbackHelperContainer(contentViewCore);
- contentViewCore.setHasPendingNavigationTransitionForTesting();
+ contentViewCore.getWebContents().setHasPendingNavigationTransitionForTesting();
TestNavigationTransitionDelegate delegate =
new TestNavigationTransitionDelegate(contentViewCore, true);
- contentViewCore.setNavigationTransitionDelegate(delegate);
+ contentViewCore.getWebContents().setNavigationTransitionDelegate(delegate);
String transitionEnteringColor = "#00FF00";
« no previous file with comments | « content/public/android/java/src/org/chromium/content_public/browser/WebContents.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698