Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments and ignored RWHVA functions from this patch Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
index 5caa21422090dda3c8d40ff1abb37c6dad6625c0..bae5e8fbc3ed0054ca33ec1401e161ca7a69eb24 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
@@ -136,6 +136,31 @@ import org.chromium.content_public.browser.WebContents;
nativeSelectWordAroundCaret(mNativeWebContentsAndroid);
}
+ @Override
+ public String getUrl() {
+ return nativeGetURL(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public boolean isIncognito() {
+ return nativeIsIncognito(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void selectPopupMenuItems(int[] indices) {
+ nativeSelectPopupMenuItems(mNativeWebContentsAndroid, indices);
+ }
+
+ @Override
+ public void resumeResponseDeferredAtStart() {
+ nativeResumeResponseDeferredAtStart(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void setHasPendingNavigationTransitionForTesting() {
+ nativeSetHasPendingNavigationTransitionForTesting(mNativeWebContentsAndroid);
+ }
+
private native String nativeGetTitle(long nativeWebContentsAndroid);
private native String nativeGetVisibleURL(long nativeWebContentsAndroid);
private native void nativeStop(long nativeWebContentsAndroid);
@@ -155,4 +180,10 @@ import org.chromium.content_public.browser.WebContents;
private native void nativeShowImeIfNeeded(long nativeWebContentsAndroid);
private native void nativeScrollFocusedEditableNodeIntoView(long nativeWebContentsAndroid);
private native void nativeSelectWordAroundCaret(long nativeWebContentsAndroid);
+ private native String nativeGetURL(long nativeWebContentsAndroid);
+ private native boolean nativeIsIncognito(long nativeWebContentsAndroid);
+ private native void nativeSelectPopupMenuItems(long nativeWebContentsAndroid, int[] indices);
+ private native void nativeResumeResponseDeferredAtStart(long nativeWebContentsAndroid);
+ private native void nativeSetHasPendingNavigationTransitionForTesting(
+ long nativeWebContentsAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698