content/browser/web_contents/web_contents_android.h - Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.h

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and ignored RWHVA functions from this patch Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_android.h

diff --git a/content/browser/web_contents/web_contents_android.h b/content/browser/web_contents/web_contents_android.h

index add9637f5290b872092167ca08b2d1a4d5d02e5d..beb70fe95eb56c1d808596763acb8ca2718556c4 100644

--- a/content/browser/web_contents/web_contents_android.h

+++ b/content/browser/web_contents/web_contents_android.h

@@ -41,6 +41,11 @@ class CONTENT_EXPORT WebContentsAndroid

jobject obj) const;

void Stop(JNIEnv* env, jobject obj);

jint GetBackgroundColor(JNIEnv* env, jobject obj);

+ base::android::ScopedJavaLocalRef<jstring> GetURL(JNIEnv* env, jobject) const;

+ jboolean IsIncognito(JNIEnv* env, jobject obj);

+ void SelectPopupMenuItems(JNIEnv* env, jobject obj, jintArray indices);

+ void ResumeResponseDeferredAtStart(JNIEnv* env, jobject obj);

+ void SetHasPendingNavigationTransitionForTesting(JNIEnv* env, jobject obj);

void OnHide(JNIEnv* env, jobject obj);

void OnShow(JNIEnv* env, jobject obj);

void PauseVideo();