Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments and ignored RWHVA functions from this patch Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 7624c74887479bfcba47634aadfa227e6fbb4a0b..5f529ea0cf18684b59e67317181601208bbc375b 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -76,9 +76,6 @@ class ContentViewCoreImpl : public ContentViewCore,
void OnJavaContentViewCoreDestroyed(JNIEnv* env, jobject obj);
- // Notifies the ContentViewCore that items were selected in the currently
- // showing select popup.
- void SelectPopupMenuItems(JNIEnv* env, jobject obj, jintArray indices);
void LoadUrl(
JNIEnv* env, jobject obj,
@@ -94,8 +91,6 @@ class ContentViewCoreImpl : public ContentViewCore,
jstring virtual_url_for_data_url,
jboolean can_load_local_resources,
jboolean is_renderer_initiated);
- base::android::ScopedJavaLocalRef<jstring> GetURL(JNIEnv* env, jobject) const;
- jboolean IsIncognito(JNIEnv* env, jobject obj);
void SendOrientationChangeEvent(JNIEnv* env, jobject obj, jint orientation);
jboolean OnTouchEvent(JNIEnv* env,
jobject obj,
@@ -209,12 +204,6 @@ class ContentViewCoreImpl : public ContentViewCore,
void SetBackgroundOpaque(JNIEnv* env, jobject jobj, jboolean opaque);
- // Notifies the main frame that it can continue navigation (if it was deferred
- // immediately at first response).
- void ResumeResponseDeferredAtStart(JNIEnv* env, jobject obj);
-
- void SetHasPendingNavigationTransitionForTesting(JNIEnv* env, jobject obj);
-
jint GetCurrentRenderProcessId(JNIEnv* env, jobject obj);
// --------------------------------------------------------------------------
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698