Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 414423002: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index a033f217b5e9560b0aecf07743f4a30bd3fa1d53..5b4532fa3cd06dd1a1dd266a897e17c773685755 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -61,11 +61,6 @@ class ContentViewCoreImpl : public ContentViewCore,
virtual float GetDpiScale() const OVERRIDE;
virtual void PauseVideo() OVERRIDE;
virtual void PauseOrResumeGeolocation(bool should_pause) OVERRIDE;
- virtual void RequestTextSurroundingSelection(
- int max_length,
- const base::Callback<void(const base::string16& content,
- int start_offset,
- int end_offset)>& callback) OVERRIDE;
// --------------------------------------------------------------------------
// Methods called from Java via JNI
@@ -78,7 +73,7 @@ class ContentViewCoreImpl : public ContentViewCore,
// Notifies the ContentViewCore that items were selected in the currently
// showing select popup.
- void SelectPopupMenuItems(JNIEnv* env, jobject obj, jintArray indices);
+// void SelectPopupMenuItems(JNIEnv* env, jobject obj, jintArray indices);
void LoadUrl(
JNIEnv* env, jobject obj,
@@ -94,8 +89,6 @@ class ContentViewCoreImpl : public ContentViewCore,
jstring virtual_url_for_data_url,
jboolean can_load_local_resources,
jboolean is_renderer_initiated);
- base::android::ScopedJavaLocalRef<jstring> GetURL(JNIEnv* env, jobject) const;
- jboolean IsIncognito(JNIEnv* env, jobject obj);
void SendOrientationChangeEvent(JNIEnv* env, jobject obj, jint orientation);
jboolean OnTouchEvent(JNIEnv* env,
jobject obj,
@@ -152,13 +145,6 @@ class ContentViewCoreImpl : public ContentViewCore,
jfloat x1, jfloat y1,
jfloat x2, jfloat y2);
void MoveCaret(JNIEnv* env, jobject obj, jfloat x, jfloat y);
- void HideTextHandles(JNIEnv* env, jobject obj);
-
- void ResetGestureDetection(JNIEnv* env, jobject obj);
- void SetDoubleTapSupportEnabled(JNIEnv* env, jobject obj, jboolean enabled);
- void SetMultiTouchZoomSupportEnabled(JNIEnv* env,
- jobject obj,
- jboolean enabled);
void ClearHistory(JNIEnv* env, jobject obj);
void EvaluateJavaScript(JNIEnv* env,
@@ -207,14 +193,6 @@ class ContentViewCoreImpl : public ContentViewCore,
jint width,
jint height);
- void SetBackgroundOpaque(JNIEnv* env, jobject jobj, jboolean opaque);
-
- // Notifies the main frame that it can continue navigation (if it was deferred
- // immediately at first response).
- void ResumeResponseDeferredAtStart(JNIEnv* env, jobject obj);
-
- void SetHasPendingNavigationTransitionForTesting(JNIEnv* env, jobject obj);
-
jint GetCurrentRenderProcessId(JNIEnv* env, jobject obj);
// --------------------------------------------------------------------------
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698