Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 35 matching lines @@
 
 class BrowserContext;
 class BrowserPluginGuestDelegate;
 class InterstitialPage;
 class PageState;
 class RenderFrameHost;
 class RenderProcessHost;
 class RenderViewHost;
 class RenderWidgetHostView;
 class SiteInstance;
+class WebContentsAndroid;
 class WebContentsDelegate;
 struct CustomContextMenuContext;
 struct DropData;
 struct RendererPreferences;
 
 // WebContents is the core class in content/. A WebContents renders web content
 // (usually HTML) in a rectangular area.
 //
 // Instantiating one is simple:
 //   scoped_ptr<content::WebContents> web_contents(
@@ skipping 506 matching lines @@
   // (and what action to take regarding the selection).
   virtual void StopFinding(StopFindAction action) = 0;
 
   // Requests the renderer to insert CSS into the main frame's document.
   virtual void InsertCSS(const std::string& css) = 0;
 
 #if defined(OS_ANDROID)
   CONTENT_EXPORT static WebContents* FromJavaWebContents(
       jobject jweb_contents_android);
   virtual base::android::ScopedJavaLocalRef<jobject> GetJavaWebContents() = 0;
+  virtual WebContentsAndroid* GetWebContentsAndroid() = 0;

[Avi (use Gerrit), 2014/08/08 15:23:25]

I don't get the relationship here.

From line 582 I see that there's something called a "JavaWebContents" that's a
jobject. From line 581 I see the opposite of that function, but that calls the
jobject a "web_contents_android". And from line 583 I see that a
"WebContentsAndroid" is an entirely different thing, a C++ class.

Can you please clarify your naming? Can we have only one special Android class
in correspondence here?

[AKVT, 2014/08/08 16:15:51]

Thanks, I think GetNativeWebContents() suits correctly. Please share your
opinion ?

[Avi (use Gerrit), 2014/08/08 16:26:04]

The name GetWebContentsAndroid is fine if you rename the parameter on line 580
(to java_web_contents or something like that). That doesn't solve the real
problem.

Before, it was clear that there was an Android corresponding object. There were
two functions, one to go WebContents → Android object (GetJavaWebContents), and
one to go Android object → WebContents (FromJavaWebContents).

OK, I can deal with that.

Now there are three functions?

You're proposing that there are two different objects that WebContents is in 1:1
relationship with. It's not immediately obvious via naming what the difference
is, and it's weird to me that one of them has two-way conversion while the other
has only one-way conversion (WebContents → WebContentsAndroid).

 #elif defined(OS_MACOSX)
   // The web contents view assumes that its view will never be overlapped by
   // another view (either partially or fully). This allows it to perform
   // optimizations. If the view is in a view hierarchy where it might be
   // overlapped by another view, notify the view by calling this with |true|.
   virtual void SetAllowOverlappingViews(bool overlapping) = 0;
 
   // Returns true if overlapping views are allowed, false otherwise.
   virtual bool GetAllowOverlappingViews() = 0;
 
   // Allowing other views disables optimizations which assume that only a single
   // WebContents is present.
   virtual void SetAllowOtherViews(bool allow) = 0;
 
   // Returns true if other views are allowed, false otherwise.
   virtual bool GetAllowOtherViews() = 0;
 #endif  // OS_ANDROID
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_