Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 414393002: Convert verification of options structs to use the new user pointer handling (see r285350). (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Convert verification of options structs to use the new user pointer handling (see r285350). This includes verification of: * MojoCreateMessagePipeOptions * MojoCreateDataPipeOptions * MojoCreateSharedBufferOptions * MojoDuplicateBufferHandleOptions It also revamps options_validation.h completely (and updates tests). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285836

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : hmm #

Patch Set 4 : hmm2 #

Patch Set 5 : win? #

Patch Set 6 : de-templatize HasMember() (MSVS isn't happy with it, I think) #

Patch Set 7 : temporarily disable part of OptionsValidationTest.InvalidDeath #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -383 lines) Patch
M mojo/system/core.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M mojo/system/data_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/data_pipe.cc View 3 chunks +23 lines, -18 lines 0 comments Download
M mojo/system/data_pipe_unittest.cc View 20 chunks +39 lines, -20 lines 0 comments Download
M mojo/system/dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 19 chunks +36 lines, -19 lines 0 comments Download
M mojo/system/memory.h View 1 2 3 4 11 chunks +76 lines, -33 lines 0 comments Download
M mojo/system/memory.cc View 4 chunks +27 lines, -12 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M mojo/system/options_validation.h View 1 2 3 4 5 1 chunk +71 lines, -91 lines 0 comments Download
M mojo/system/options_validation_unittest.cc View 1 2 3 4 5 6 1 chunk +85 lines, -139 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.h View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 4 chunks +24 lines, -16 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher_unittest.cc View 9 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-26 04:52:56 UTC) #1
darin (slow to review)
LGTM (This sequence of patches is all a nice improvement by the way!)
6 years, 5 months ago (2014-07-26 05:17:15 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-26 20:01:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/414393002/20001
6 years, 5 months ago (2014-07-26 20:03:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-26 20:44:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-26 20:49:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/109)
6 years, 5 months ago (2014-07-26 20:49:53 UTC) #7
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 4 months ago (2014-07-27 05:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/414393002/110001
6 years, 4 months ago (2014-07-27 05:34:12 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-27 11:29:36 UTC) #10
Message was sent while issue was closed.
Change committed as 285836

Powered by Google App Engine
This is Rietveld 408576698