Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 414383002: Run android tests through runtest.py. (Closed)

Created:
6 years, 5 months ago by zty
Modified:
6 years, 4 months ago
Reviewers:
navabi1, jbudorick, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Run android tests through runtest.py. This CL re-lands https://codereview.chromium.org/410033002 while addressed a few issues. 1. --results-directory must be passed along with --generate-gtest-json 2. --test-platform, --annotate, --build-number, --builder-name should be passed in order to upload results to correct dashboard 3. This CL depends on https://codereview.chromium.org/414223011/ to fix a bug in runtest.py BUG=329102 R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288134

Patch Set 1 #

Patch Set 2 : Fix Command #

Patch Set 3 : Added test-platform and fix argument type." #

Patch Set 4 : Runtest with runtest.py #

Patch Set 5 : Always pass test-platform to runtest.py #

Patch Set 6 : Fix CWD #

Patch Set 7 : fix --target argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 3 4 5 6 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
zty
ptal.
6 years, 5 months ago (2014-07-26 04:43:06 UTC) #1
zty
ping
6 years, 4 months ago (2014-08-04 19:22:41 UTC) #2
Yaron
didn't this land once and was reverted? what's different this time? Please refer to it ...
6 years, 4 months ago (2014-08-04 19:27:10 UTC) #3
zty
Updated CL description. navabi@ is listed as owner of bb_device_steps.py, you and jbudorick are the ...
6 years, 4 months ago (2014-08-04 21:37:21 UTC) #4
Yaron
lgtm
6 years, 4 months ago (2014-08-05 16:28:12 UTC) #5
navabi1
lgtm
6 years, 4 months ago (2014-08-06 18:50:05 UTC) #6
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-06 20:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/414383002/60001
6 years, 4 months ago (2014-08-06 20:42:34 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 22:08:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 22:30:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3087)
6 years, 4 months ago (2014-08-06 22:30:40 UTC) #11
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-07 02:02:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/414383002/80001
6 years, 4 months ago (2014-08-07 02:03:20 UTC) #13
zty
The CQ bit was unchecked by zty@chromium.org
6 years, 4 months ago (2014-08-07 03:18:00 UTC) #14
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-07 16:45:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/414383002/100001
6 years, 4 months ago (2014-08-07 16:46:51 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 20:16:05 UTC) #17
commit-bot: I haz the power
Change committed as 288134
6 years, 4 months ago (2014-08-07 20:25:23 UTC) #18
Albert Bodenhamer
6 years, 4 months ago (2014-08-07 21:45:54 UTC) #19
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/455493002/ by abodenha@chromium.org.

The reason for reverting is: Looks like the cause of
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
failing.

runtest.py was repeatedly unable to find the test targets it was supposed to
run.

partial log:
@@@BUILD_STEP base_unittests@@@
> /b/build/scripts/slave/runtest.py
'--factory-properties={"generate_gtest_json": true, "target": "Debug",
"gclient_env": {}, "build_url":
"http://build1-a1/b/build/slave/Android_Builder__dbg_/chrome_staging/full-build-linux.zip",
"clobber": false, "GYP_DEFINES": " component=shared_library", "target_os":
"android", "android_bot_id": "main-tests-dbg"}'
'--build-properties={"parentname": "Android Builder (dbg)", "got_nacl_revision":
"13580", "parent_wk_revision": "179716", "parent_got_v8_revision": "22960",
"parent_got_swarming_client_revision":
"bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "got_revision": "288139",
"parent_revision": "288139", "blamelist_real": ["achaulk@chromium.org",
"jamescook@chromium.org", "mef@chromium.org", "morrita@chromium.org",
"varkha@chromium.org", "zty@chromium.org (:zty)"], "got_webkit_revision_git":
"08c40136a44dd5b3f5bf976d5c75e7623afb8e29", "parent_slavename": "build1-a1",
"got_v8_revision_git": "9d72b8dd94263d9f500f18255d67f0c7b8c3527a",
"got_webrtc_revision_git": "a288b8cbb568cbf1735e6d5d0012524f4f8e5f74",
"buildnumber": 22085, "got_webkit_revision": "179716", "parent_scheduler":
"android", "got_swarming_client_revision":
"bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "parent_buildnumber": "63404",
"slavename": "build42-a1", "blamelist":
"achaulk@chromium.org,jamescook@chromium.org,mef@chromium.org,morrita@chromiu...,
"branch": "src", "patchset": "", "issue": "", "revision": "288139", "workdir":
"/b/build/slave/Android_Tests__dbg_", "repository":
"svn://svn-mirror.golo.chromium.org/chrome/trunk", "buildername": "Android Tests
(dbg)", "parent_try_job_key": "", "got_webrtc_revision": "6825", "mastername":
"chromium.linux", "parent_got_webkit_revision": "179716", "parent_builddir": "",
"parent_branch": "src", "got_nacl_revision_git":
"1fb9738130a80c961cf1ed46cdb38caf0d165543", "scheduler": "android_trigger_dbg",
"requester": "", "buildbotURL": "http://build.chromium.org/p/chromium.linux/",
"parent_cr_revision": "288139", "got_revision_git":
"3afe85add41986693e47da5e33a01a2989c96354", "rietveld": "",
"parent_got_nacl_revision": "13580", "parent_buildername": "Android Builder
(dbg)", "got_v8_revision": "22960", "parent_got_revision": "288139", "project":
"", "patch_url": "", "parentslavename": "build1-a1", "root": "", "primary_repo":
""}' --test-platform android --generate-json-file -o
gtest-results/base_unittests --annotate gtest --build-number 22085
--builder-name 'Android Tests (dbg)' base_unittests --verbose
[Running on builder: "Android Tests (dbg)"]
DBUS_SESSION_BUS_ADDRESS env var not found, starting dbus-launch
 setting DBUS_SESSION_BUS_ADDRESS to
unix:abstract=/tmp/dbus-p2NSrlwT6t,guid=118a14e22115547464aef590000002f4
 setting DBUS_SESSION_BUS_PID to 8386
Additional test environment:
 
LLVM_SYMBOLIZER_PATH=/b/build/slave/Android_Tests__dbg_/build/src/third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer

src/build/android/test_runner.py gtest --release -s base_unittests
Traceback (most recent call last):
  File "src/build/android/test_runner.py", line 836, in <module>
    sys.exit(main())
  File "src/build/android/test_runner.py", line 832, in main
    return command_option_parser.ParseAndExecute(option_parser)
  File
"/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/utils/command_option_parser.py",
line 75, in ParseAndExecute
    return cmd.run_command_func(argv[1], options, args, option_parser)
  File "src/build/android/test_runner.py", line 746, in RunTestsCommand
    return _RunGTests(options, devices)
  File "src/build/android/test_runner.py", line 527, in _RunGTests
    runner_factory, tests = gtest_setup.Setup(gtest_options, devices)
  File
"/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/gtest/setup.py",
line 325, in Setup
    % test_options.suite_name)
Exception: Did not find base_unittests target. Ensure it has been built.
using JSON summary output instead of gtest XML
No data was available to update the JSON results.

Powered by Google App Engine
This is Rietveld 408576698