Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 414333002: Revert of Run android tests through runtest.py. (Closed)

Created:
6 years, 5 months ago by Mark P
Modified:
6 years, 5 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Run android tests through runtest.py. (https://codereview.chromium.org/410033002/) Reason for revert: Causes failures: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14823/ error: --results-directory is required with --generate-json-file=True Original issue's description: > Run android tests through runtest.py. > > BUG=329102 > R=qyearsley@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285667 TBR=qyearsley@chromium.org,jbudorick@chromium.org,klundberg@chromium.org,navabi@chromium.org,yfriedman@chromium.org,eseidel@chromium.org,zty@chromium.org NOTREECHECKS=true NOTRY=true BUG=329102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M build/android/buildbot/bb_device_steps.py View 2 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Mark P
Created Revert of Run android tests through runtest.py.
6 years, 5 months ago (2014-07-25 22:52:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/414333002/1
6 years, 5 months ago (2014-07-25 22:56:07 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 22:57:27 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/android/buildbot/bb_device_steps.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-25 22:57:28 UTC) #4
ghost stip (do not use)
The CQ bit was checked by stip@chromium.org
6 years, 5 months ago (2014-07-25 23:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/414333002/1
6 years, 5 months ago (2014-07-25 23:10:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 23:11:54 UTC) #7
commit-bot: I haz the power
Failed to apply patch for build/android/buildbot/bb_device_steps.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-25 23:11:54 UTC) #8
ghost stip (do not use)
this revert is failing because the git-svn sync is failing. it should clear up in ...
6 years, 5 months ago (2014-07-25 23:25:29 UTC) #9
ghost stip (do not use)
The CQ bit was checked by stip@chromium.org
6 years, 5 months ago (2014-07-25 23:27:02 UTC) #10
jbudorick
On 2014/07/25 23:25:29, stip wrote: > this revert is failing because the git-svn sync is ...
6 years, 5 months ago (2014-07-25 23:27:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/414333002/1
6 years, 5 months ago (2014-07-25 23:29:12 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 23:30:56 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 23:30:57 UTC) #14 
Failed to apply patch for build/android/buildbot/bb_device_steps.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/android/buildbot/bb_device_steps.py
  Hunk #1 FAILED at 96.
  Hunk #2 FAILED at 148.
  2 out of 2 hunks FAILED -- saving rejects to file
build/android/buildbot/bb_device_steps.py.rej

Patch:       build/android/buildbot/bb_device_steps.py
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py
b/build/android/buildbot/bb_device_steps.py
index
9a2149213bb722315df830bd23568d1027177b91..1d0ba35fff139a91054d01bf46ae16ff7c710ec9
100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -96,29 +96,6 @@
   return revision
 
 
-def _RunTest(options, cmd, suite):
-  """Run test command with runtest.py.
-
-  Args:
-    options: options object.
-    cmd: the command to run.
-    suite: test name.
-  """
-  property_args = bb_utils.EncodeProperties(options)
-  args = [os.path.join(SLAVE_SCRIPTS_DIR, 'runtest.py'),
-      '--test-type',
-      suite,
-      '--run-python-script'
-    ] + property_args
-  if options.factory_properties.get('generate_gtest_json'):
-    args.append('--generate-json-file')
-
-  if options.target == 'Release':
-    args += ['--target', 'Release']
-  args += cmd
-  RunCmd(args)
-
-
 def RunTestSuites(options, suites, suites_options=None):
   """Manages an invocation of test_runner.py for gtests.
 
@@ -148,7 +125,7 @@
     cmd += suites_options.get(suite, [])
     if suite == 'content_browsertests':
       cmd.append('--num_retries=1')
-    _RunTest(options, cmd, suite)
+    RunCmd(cmd)
 
 
 def RunChromeDriverTests(options):

Powered by Google App Engine
This is Rietveld 408576698