Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome_frame/test/ui_test.cc

Issue 4143004: Disabling a number of failing chrome frame tests on Vista with IE7. Most of t... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/test_with_web_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/ui_test.cc
===================================================================
--- chrome_frame/test/ui_test.cc (revision 64148)
+++ chrome_frame/test/ui_test.cc (working copy)
@@ -9,6 +9,7 @@
#include "base/utf_string_conversions.h"
#include "base/win/scoped_bstr.h"
#include "base/win/scoped_variant.h"
+#include "base/win/windows_version.h"
#include "chrome/common/url_constants.h"
#include "chrome_frame/test/chrome_frame_test_utils.h"
#include "chrome_frame/test/chrome_frame_ui_test_utils.h"
@@ -222,6 +223,14 @@
// Tests that view source works.
TEST_P(FullTabUITest, ViewSource) {
+ // Please see http://code.google.com/p/chromium/issues/detail?id=60987
+ // for more information on why this test is disabled for Vista with IE7.
+ if (base::win::GetVersion() == base::win::VERSION_VISTA &&
+ GetInstalledIEVersion() == IE_7) {
+ LOG(INFO) << "Not running test on Vista with IE7";
+ return;
+ }
+
bool in_cf = GetParam().invokes_cf();
if (!in_cf) {
LOG(ERROR) << "Test not implemented for this configuration.";
@@ -414,6 +423,13 @@
// Test view source from the context menu.
TEST_F(ContextMenuTest, CFViewSource) {
+ // Please see http://code.google.com/p/chromium/issues/detail?id=60987
+ // for more information on why this test is disabled for Vista with IE7.
+ if (base::win::GetVersion() == base::win::VERSION_VISTA &&
+ GetInstalledIEVersion() == IE_7) {
+ LOG(INFO) << "Not running test on Vista with IE7";
+ return;
+ }
server_mock_.ExpectAndServeAnyRequests(CFInvocation::MetaTag());
MockIEEventSink view_source_mock;
view_source_mock.ExpectAnyNavigations();
@@ -500,15 +516,36 @@
}
TEST_F(ContextMenuTest, CFSavePageAs) {
+ // Please see http://code.google.com/p/chromium/issues/detail?id=60987
+ // for more information on why this test is disabled for Vista with IE7.
+ if (base::win::GetVersion() == base::win::VERSION_VISTA &&
+ GetInstalledIEVersion() == IE_7) {
+ LOG(INFO) << "Not running test on Vista with IE7";
+ return;
+ }
ASSERT_NO_FATAL_FAILURE(DoSaveAsTest(L"", L"Save as...", L".html"));
}
TEST_F(ContextMenuTest, CFSaveLinkAs) {
+ // Please see http://code.google.com/p/chromium/issues/detail?id=60987
+ // for more information on why this test is disabled for Vista with IE7.
+ if (base::win::GetVersion() == base::win::VERSION_VISTA &&
+ GetInstalledIEVersion() == IE_7) {
+ LOG(INFO) << "Not running test on Vista with IE7";
+ return;
+ }
ASSERT_NO_FATAL_FAILURE(DoSaveAsTest(L"link", L"Save link as...", L".zip"));
}
// This tests that the about:version page can be opened via the CF context menu.
TEST_F(ContextMenuTest, CFAboutVersionLoads) {
+ // Please see http://code.google.com/p/chromium/issues/detail?id=60987
+ // for more information on why this test is disabled for Vista with IE7.
+ if (base::win::GetVersion() == base::win::VERSION_VISTA &&
+ GetInstalledIEVersion() == IE_7) {
+ LOG(INFO) << "Not running test on Vista with IE7";
+ return;
+ }
server_mock_.ExpectAndServeAnyRequests(CFInvocation::MetaTag());
const wchar_t* kAboutVersionUrl = L"gcf:about:version";
const wchar_t* kAboutVersionWithoutProtoUrl = L"about:version";
« no previous file with comments | « chrome_frame/test/test_with_web_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698