Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 414253004: Introduce TracingController and TracingControllerBackend skeleton (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready_to_land Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/tab_unittest.py
diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py
index bf9250edc897154a5d3e150c6574c4ce6a583ddc..6f1389ade9be07baf89d742b5d73cf057c483cb9 100644
--- a/tools/telemetry/telemetry/core/tab_unittest.py
+++ b/tools/telemetry/telemetry/core/tab_unittest.py
@@ -10,7 +10,7 @@ from telemetry.core import bitmap
from telemetry.core import video
from telemetry.core import util
from telemetry.core import exceptions
-from telemetry.core.backends.chrome import tracing_backend
+from telemetry.core.platform import tracing_category_filter
from telemetry.timeline import model
from telemetry.unittest import tab_test_case
@@ -23,6 +23,13 @@ class FakePlatformBackend(object):
def __init__(self):
self.platform = FakePlatform()
+ def DidStartBrowser(self, _, _2):
+ pass
+
+ def WillCloseBrowser(self, _, _2):
+ pass
+
+
class FakePlatform(object):
def __init__(self):
self._is_video_capture_running = False
@@ -35,9 +42,6 @@ class FakePlatform(object):
self._is_video_capture_running = False
return video.Video(tempfile.NamedTemporaryFile())
- def SetFullPerformanceModeEnabled(self, enabled):
- pass
-
@property
def is_video_capture_running(self):
return self._is_video_capture_running
@@ -100,7 +104,7 @@ class TabTest(tab_test_case.TabTestCase):
def testHighlight(self):
self.assertEquals(self._tab.url, 'about:blank')
- self._browser.StartTracing(tracing_backend.DEFAULT_TRACE_CATEGORIES)
+ self._browser.StartTracing()
self._tab.Highlight(bitmap.WEB_PAGE_TEST_ORANGE)
self._tab.ClearHighlight(bitmap.WEB_PAGE_TEST_ORANGE)
trace_data = self._browser.StopTracing()
@@ -127,7 +131,8 @@ class TabTest(tab_test_case.TabTestCase):
third_tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
third_tab.Close()
- self._browser.StartTracing(tracing_backend.MINIMAL_TRACE_CATEGORIES)
+ self._browser.StartTracing(
+ tracing_category_filter.CreateNoOverheadFilter())
first_tab.ExecuteJavaScript('console.time("first-tab-marker");')
first_tab.ExecuteJavaScript('console.timeEnd("first-tab-marker");')
second_tab.ExecuteJavaScript('console.time("second-tab-marker");')

Powered by Google App Engine
This is Rietveld 408576698