Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 414243002: Changed PLOG to VPLOG (Closed)

Created:
6 years, 5 months ago by GG
Modified:
6 years, 4 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changed PLOG to VPLOG Moved recvmsg log to VPLOG BUG=377403 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288259

Patch Set 1 #

Patch Set 2 : Changed to DVLOG(1) #

Patch Set 3 : Adding myself in AUTHORS #

Patch Set 4 : Updated the patch after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
GG
PTAL
6 years, 5 months ago (2014-07-25 10:16:10 UTC) #1
yzshen1
On 2014/07/25 10:16:10, giji.g wrote: > PTAL I notice the other warning associated with the ...
6 years, 5 months ago (2014-07-25 17:35:27 UTC) #2
GG
Changed it to DVLOG_IF(1,condition) as it is conditional logging. PTAL.
6 years, 4 months ago (2014-07-30 06:20:51 UTC) #3
yzshen1
lgtm
6 years, 4 months ago (2014-07-30 07:04:19 UTC) #4
GG
The CQ bit was checked by giji.g@samsung.com
6 years, 4 months ago (2014-07-30 10:35:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/giji.g@samsung.com/414243002/20001
6 years, 4 months ago (2014-07-30 10:37:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-30 12:15:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 12:18:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/925)
6 years, 4 months ago (2014-07-30 12:18:29 UTC) #9
yzshen1
On 2014/07/30 12:18:29, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-07-30 17:31:11 UTC) #10
GG
My name is added to CLA and AUTHORS list please cross check.
6 years, 4 months ago (2014-08-07 04:16:26 UTC) #11
yzshen1
On 2014/08/07 04:16:26, GG wrote: > My name is added to CLA and AUTHORS list ...
6 years, 4 months ago (2014-08-07 16:51:33 UTC) #12
GG
The CQ bit was checked by giji.g@samsung.com
6 years, 4 months ago (2014-08-08 03:49:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/giji.g@samsung.com/414243002/40001
6 years, 4 months ago (2014-08-08 03:52:25 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-08 04:29:23 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 04:32:03 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38951) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/3694) ios_rel_device ...
6 years, 4 months ago (2014-08-08 04:32:05 UTC) #17
GG
The CQ bit was checked by giji.g@samsung.com
6 years, 4 months ago (2014-08-08 06:51:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/giji.g@samsung.com/414243002/60001
6 years, 4 months ago (2014-08-08 06:53:55 UTC) #19
commit-bot: I haz the power
Change committed as 288259
6 years, 4 months ago (2014-08-08 08:32:33 UTC) #20
viettrungluu
On 2014/08/08 08:32:33, I haz the power (commit-bot) wrote: > Change committed as 288259 Whoa! ...
6 years, 4 months ago (2014-08-08 16:17:38 UTC) #21
viettrungluu
6 years, 4 months ago (2014-08-08 16:23:01 UTC) #22
Message was sent while issue was closed.
On 2014/08/08 16:17:38, viettrungluu wrote:
> On 2014/08/08 08:32:33, I haz the power (commit-bot) wrote:
> > Change committed as 288259
> 
> Whoa! This was deliberately NOT changed to a DVLOG because it likely indicates
a
> bug.

I'm reverting this.

Powered by Google App Engine
This is Rietveld 408576698