Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Issue 414233002: DevTools: Clear current target in TimelineModelImpl's reset only if timeline is not recording (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Clear current target in TimelineModelImpl's reset only if timeline is not recording BUG=397216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179148

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-25 10:16:42 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-07-29 12:05:18 UTC) #2
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-07-29 12:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/414233002/20001
6 years, 4 months ago (2014-07-29 12:46:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 13:52:12 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:53:21 UTC) #6
Message was sent while issue was closed.
Change committed as 179148

Powered by Google App Engine
This is Rietveld 408576698