Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 414223006: Revert of Blink roll 178929:178934 (Closed)

Created:
6 years, 5 months ago by dmichael (off chromium)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Blink roll 178929:178934 (https://codereview.chromium.org/417113005/) Reason for revert: Seems to have broken browser_tests: DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch (run #4): [ RUN ] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch HTTP server started on http://127.0.0.1:52329... sending server_data: {"host": "127.0.0.1", "port": 52329} (36 bytes) ../../chrome/browser/devtools/devtools_sanity_browsertest.cc:104: Failure Value of: result Actual: "[FAILED] TypeError: Cannot read property 'sourcesView' of undefined" Expected: "[OK]" Original issue's description: > Blink roll 178929:178934 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178934&mode=html > TBR=haraken@chromium.org,jchaffraix@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285602 TBR=haraken@chromium.org,jchaffraix@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dmichael (off chromium)
Created Revert of Blink roll 178929:178934
6 years, 5 months ago (2014-07-25 18:37:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/414223006/1
6 years, 5 months ago (2014-07-25 18:38:18 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 18:39:55 UTC) #3
Message was sent while issue was closed.
Change committed as 285622

Powered by Google App Engine
This is Rietveld 408576698