Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 414203003: Remove unnecessary utilities from drive::util. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary utilities from drive::util. * drive::util::GetHostedDocumentMimeType is useless, the mime type is directly obtained from ResourceEntry, especially after we've moved to Drive API (see Bug 308836 for subtlety). * kWapiRootDirectoryResourceId is just not used anywhere. BUG=397391 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285543

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M chrome/browser/chromeos/drive/search_metadata.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_api_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/drive/drive_api_util.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
6 years, 5 months ago (2014-07-25 02:26:04 UTC) #1
hashimoto
lgtm!
6 years, 5 months ago (2014-07-25 03:23:46 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-25 03:24:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/414203003/1
6 years, 5 months ago (2014-07-25 03:26:44 UTC) #4
kinaba
The CQ bit was unchecked by kinaba@chromium.org
6 years, 5 months ago (2014-07-25 04:28:49 UTC) #5
kinaba
Fixed SearchMetadataTest to assign a mime type to test metadata.
6 years, 5 months ago (2014-07-25 04:29:50 UTC) #6
hashimoto
lgtm++
6 years, 5 months ago (2014-07-25 04:33:59 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-25 04:46:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/414203003/20001
6 years, 5 months ago (2014-07-25 04:48:40 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:31:00 UTC) #10
Message was sent while issue was closed. 
Change committed as 285543

Powered by Google App Engine
This is Rietveld 408576698