Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3914)

Unified Diff: chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc

Issue 414203002: Modified tab change to work with status tray change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if no accessible ancestor, original view is returned Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
diff --git a/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc b/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
index 915b072a7c22a8406221328a9c4a60313a14cba4..e81d6ba7a419e39ca0288edd1dd68ef0b6f2bf9d 100644
--- a/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
+++ b/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
@@ -591,8 +591,12 @@ std::string AccessibilityEventRouterViews::RecursiveGetStaticText(
// static
views::View* AccessibilityEventRouterViews::FindFirstAccessibleAncestor(
views::View* view) {
- while (view->parent() && !view->IsAccessibilityFocusable()) {
- view = view->parent();
+ views::View* temp_view = view;
+ while (temp_view->parent() && !temp_view->IsAccessibilityFocusable()) {
+ temp_view = temp_view->parent();
}
sky 2014/07/25 20:14:26 nit: no {} here.
evy 2014/07/25 20:55:31 Done.
- return view;
+ if (temp_view->IsAccessibilityFocusable())
+ return temp_view;
+ else
sky 2014/07/25 20:14:26 nit: no else here, see style guide.
evy 2014/07/25 20:55:31 Done.
+ return view;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698