Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: mojo/shell/dynamic_service_loader.cc

Issue 414173004: mojo: fix little bug in DynamicServiceLoader/Runner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: oopsies Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojo.gyp ('k') | mojo/shell/dynamic_service_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/dynamic_service_loader.cc
diff --git a/mojo/shell/dynamic_service_loader.cc b/mojo/shell/dynamic_service_loader.cc
index 5939d4b12003320f69c31d35c4e80d3600e83959..a8e6914ae9e5a8bb3cd18ffa4e22dc51fd75b58d 100644
--- a/mojo/shell/dynamic_service_loader.cc
+++ b/mojo/shell/dynamic_service_loader.cc
@@ -67,8 +67,6 @@ class LocalLoader : public Loader {
base::FilePath path;
net::FileURLToFilePath(url, &path);
- // TODO(darin): Check if the given file path exists.
-
// Complete asynchronously for consistency with NetworkServiceLoader.
base::MessageLoop::current()->PostTask(
FROM_HERE,
@@ -76,7 +74,7 @@ class LocalLoader : public Loader {
base::Unretained(this),
path,
base::Passed(&service_handle),
- true));
+ base::PathExists(path)));
}
};
« no previous file with comments | « mojo/mojo.gyp ('k') | mojo/shell/dynamic_service_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698