Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 414163003: Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc (revision 38626)
+++ runtime/vm/intermediate_language_arm.cc (working copy)
@@ -1092,11 +1092,8 @@
case kTypedDataInt32ArrayCid:
case kTypedDataUint32ArrayCid:
- // Result can be Smi or Mint when boxed.
- // Instruction can deoptimize if we optimistically assumed that the result
- // fits into Smi.
- return CanDeoptimize() ? CompileType::FromCid(kSmiCid)
- : CompileType::Int();
+ return Typed32BitIsSmi() ? CompileType::FromCid(kSmiCid)
+ : CompileType::FromCid(kMintCid);
default:
UNREACHABLE();
@@ -1121,9 +1118,7 @@
return kTagged;
case kTypedDataInt32ArrayCid:
case kTypedDataUint32ArrayCid:
- // Instruction can deoptimize if we optimistically assumed that the result
- // fits into Smi.
- return CanDeoptimize() ? kTagged : kUnboxedMint;
+ return Typed32BitIsSmi() ? kTagged : kUnboxedMint;
case kTypedDataFloat32ArrayCid:
case kTypedDataFloat64ArrayCid:
return kUnboxedDouble;
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698