Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 414163003: Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 38626)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -1659,9 +1659,8 @@
intptr_t deopt_id = Isolate::kNoDeoptId;
if ((array_cid == kTypedDataInt32ArrayCid) ||
(array_cid == kTypedDataUint32ArrayCid)) {
- // Prevent excessive deoptimization, assume full 32 bits used, and therefore
- // generate Mint on 32-bit architectures.
- deopt_id = (kSmiBits < 32) ? Isolate::kNoDeoptId : call->deopt_id();
+ // Deoptimization may be needed if result does not always fit in a Smi.
+ deopt_id = (kSmiBits >= 32) ? Isolate::kNoDeoptId : call->deopt_id();
}
// Array load and return.
@@ -3555,9 +3554,8 @@
intptr_t deopt_id = Isolate::kNoDeoptId;
if ((array_cid == kTypedDataInt32ArrayCid) ||
(array_cid == kTypedDataUint32ArrayCid)) {
- // Prevent excessive deoptimization, assume full 32 bits used, and therefore
- // generate Mint on 32-bit architectures.
- deopt_id = (kSmiBits < 32) ? Isolate::kNoDeoptId : call->deopt_id();
+ // Deoptimization may be needed if result does not always fit in a Smi.
+ deopt_id = (kSmiBits >= 32) ? Isolate::kNoDeoptId : call->deopt_id();
}
*last = new(I) LoadIndexedInstr(new(I) Value(array),
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698