Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 414163003: Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 38576)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -993,8 +993,8 @@
// Result can be Smi or Mint when boxed.
// Instruction can deoptimize if we optimistically assumed that the result
// fits into Smi.
- return CanDeoptimize() ? CompileType::FromCid(kSmiCid)
- : CompileType::Int();
+ return Typed32BitIsSmi() ? CompileType::FromCid(kSmiCid)
+ : CompileType::FromCid(kMintCid);
default:
UNIMPLEMENTED();
@@ -1003,6 +1003,10 @@
}
+// TODO(srdjan): Implement this as a flag so that it can be optimized.
+bool LoadIndexedInstr::Typed32BitIsSmi() const { return false; }
+
+
Representation LoadIndexedInstr::representation() const {
switch (class_id_) {
case kArrayCid:
@@ -1019,9 +1023,7 @@
return kTagged;
case kTypedDataInt32ArrayCid:
case kTypedDataUint32ArrayCid:
- // Instruction can deoptimize if we optimistically assumed that the result
- // fits into Smi.
- return CanDeoptimize() ? kTagged : kUnboxedMint;
+ return Typed32BitIsSmi() ? kTagged : kUnboxedMint;
case kTypedDataFloat32ArrayCid:
case kTypedDataFloat64ArrayCid:
return kUnboxedDouble;

Powered by Google App Engine
This is Rietveld 408576698