Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 908 matching lines @@
     case kTypedDataUint32ArrayCid:
       return CompileType::FromCid(kSmiCid);
 
     default:
       UNIMPLEMENTED();
       return CompileType::Dynamic();
   }
 }
 
 
+bool  LoadIndexedInstr::Typed32BitIsSmi() const { return true; }

[Vyacheslav Egorov (Google), 2014/07/26 07:33:49]

Remove one space between bool and LoadIndexedInstr (ditto in other files). 

You could have defined it in the platform independent file as 

return kSmiBits >= 32 

[srdjan, 2014/07/28 16:50:49]

Done. 

The idea was to change a flag  on 32 bit architecture when we detect a Smi
output (CheckSmi consumes output of LaodIndexed). I will split it up once/if I
implement it.

+
+
 Representation LoadIndexedInstr::representation() const {
   switch (class_id_) {
     case kArrayCid:
     case kImmutableArrayCid:
     case kTypedDataInt8ArrayCid:
     case kTypedDataUint8ArrayCid:
     case kTypedDataUint8ClampedArrayCid:
     case kExternalTypedDataUint8ArrayCid:
     case kExternalTypedDataUint8ClampedArrayCid:
     case kTypedDataInt16ArrayCid:
@@ skipping 4829 matching lines @@
   __ movq(R10, Immediate(kInvalidObjectPointer));
   __ movq(RBX, Immediate(kInvalidObjectPointer));
 #endif
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64