Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 414163003: Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 return CanDeoptimize() ? CompileType::FromCid(kSmiCid) 1062 return CanDeoptimize() ? CompileType::FromCid(kSmiCid)
1063 : CompileType::Int(); 1063 : CompileType::Int();
1064 1064
1065 default: 1065 default:
1066 UNIMPLEMENTED(); 1066 UNIMPLEMENTED();
1067 return CompileType::Dynamic(); 1067 return CompileType::Dynamic();
1068 } 1068 }
1069 } 1069 }
1070 1070
1071 1071
1072 // TODO(srdjan): Implement this as a flag so that it can be optimized.
1073 bool LoadIndexedInstr::Typed32BitIsSmi() const { return false; }
1074
1075
1072 Representation LoadIndexedInstr::representation() const { 1076 Representation LoadIndexedInstr::representation() const {
1073 switch (class_id_) { 1077 switch (class_id_) {
1074 case kArrayCid: 1078 case kArrayCid:
1075 case kImmutableArrayCid: 1079 case kImmutableArrayCid:
1076 case kTypedDataInt8ArrayCid: 1080 case kTypedDataInt8ArrayCid:
1077 case kTypedDataUint8ArrayCid: 1081 case kTypedDataUint8ArrayCid:
1078 case kTypedDataUint8ClampedArrayCid: 1082 case kTypedDataUint8ClampedArrayCid:
1079 case kExternalTypedDataUint8ArrayCid: 1083 case kExternalTypedDataUint8ArrayCid:
1080 case kExternalTypedDataUint8ClampedArrayCid: 1084 case kExternalTypedDataUint8ClampedArrayCid:
1081 case kTypedDataInt16ArrayCid: 1085 case kTypedDataInt16ArrayCid:
(...skipping 3698 matching lines...) Expand 10 before | Expand all | Expand 10 after
4780 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 4784 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
4781 #if defined(DEBUG) 4785 #if defined(DEBUG)
4782 __ LoadImmediate(S4, kInvalidObjectPointer); 4786 __ LoadImmediate(S4, kInvalidObjectPointer);
4783 __ LoadImmediate(S5, kInvalidObjectPointer); 4787 __ LoadImmediate(S5, kInvalidObjectPointer);
4784 #endif 4788 #endif
4785 } 4789 }
4786 4790
4787 } // namespace dart 4791 } // namespace dart
4788 4792
4789 #endif // defined TARGET_ARCH_MIPS 4793 #endif // defined TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698