Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 414163003: Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1087 matching lines...) Expand 10 before | Expand all | Expand 10 after
1098 return CanDeoptimize() ? CompileType::FromCid(kSmiCid) 1098 return CanDeoptimize() ? CompileType::FromCid(kSmiCid)
1099 : CompileType::Int(); 1099 : CompileType::Int();
1100 1100
1101 default: 1101 default:
1102 UNREACHABLE(); 1102 UNREACHABLE();
1103 return CompileType::Dynamic(); 1103 return CompileType::Dynamic();
1104 } 1104 }
1105 } 1105 }
1106 1106
1107 1107
1108 // TODO(srdjan): Implement this as a flag so that it can be optimized.
1109 bool LoadIndexedInstr::Typed32BitIsSmi() const { return false; }
1110
1111
1108 Representation LoadIndexedInstr::representation() const { 1112 Representation LoadIndexedInstr::representation() const {
1109 switch (class_id_) { 1113 switch (class_id_) {
1110 case kArrayCid: 1114 case kArrayCid:
1111 case kImmutableArrayCid: 1115 case kImmutableArrayCid:
1112 case kTypedDataInt8ArrayCid: 1116 case kTypedDataInt8ArrayCid:
1113 case kTypedDataUint8ArrayCid: 1117 case kTypedDataUint8ArrayCid:
1114 case kTypedDataUint8ClampedArrayCid: 1118 case kTypedDataUint8ClampedArrayCid:
1115 case kExternalTypedDataUint8ArrayCid: 1119 case kExternalTypedDataUint8ArrayCid:
1116 case kExternalTypedDataUint8ClampedArrayCid: 1120 case kExternalTypedDataUint8ClampedArrayCid:
1117 case kTypedDataInt16ArrayCid: 1121 case kTypedDataInt16ArrayCid:
(...skipping 5498 matching lines...) Expand 10 before | Expand all | Expand 10 after
6616 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 6620 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
6617 #if defined(DEBUG) 6621 #if defined(DEBUG)
6618 __ LoadImmediate(R4, kInvalidObjectPointer); 6622 __ LoadImmediate(R4, kInvalidObjectPointer);
6619 __ LoadImmediate(R5, kInvalidObjectPointer); 6623 __ LoadImmediate(R5, kInvalidObjectPointer);
6620 #endif 6624 #endif
6621 } 6625 }
6622 6626
6623 } // namespace dart 6627 } // namespace dart
6624 6628
6625 #endif // defined TARGET_ARCH_ARM 6629 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698