Issue 414133002: Revert 285393 "Exit overview mode when a new activity is opened ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414133002: Revert 285393 "Exit overview mode when a new activity is opened ..." (Closed)

Created:
6 years, 5 months ago by not at google - send to devlin

Modified:
6 years, 5 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 285393 "Exit overview mode when a new activity is opened ..." Broke HomeCardTest.Accelerators: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/46117 > Exit overview mode when a new activity is opened in athena. > > This has the side effect of fixing the crash in 396368 > > BUG=396368 > TEST=Manual, see bug > > Review URL: https://codereview.chromium.org/411813002 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285398

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -18 lines)			Patch
	M	trunk/src/athena/home/home_card_unittest.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
	M	trunk/src/athena/wm/window_manager_impl.cc	View		4 chunks	+8 lines, -18 lines	0 comments	Download

Total messages: 2 (0 generated)

not at google - send to devlin

6 years, 5 months ago (2014-07-24 23:01:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r285398 (tree was closed).