Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 414123006: RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout This CL swiches RenderBlock::layoutPositionedObjects from using setNeedsLayout to setNeedsPositionedMovementLayout, as indicated by the FIXME comment and associated bug. The test failure mentioned in the bug is no longer a problem. BUG=350756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -43 lines) Patch
M LayoutTests/fast/repaint/bugzilla-6388-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/android/fast/repaint/bugzilla-6388-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/bugzilla-6388-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/bugzilla-6388-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-07-30 21:39:05 UTC) #1
abarth-chromium
Depends on https://codereview.chromium.org/429363002
6 years, 4 months ago (2014-07-30 21:39:57 UTC) #2
Julien - ping for review
lgtm
6 years, 4 months ago (2014-07-30 22:36:22 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-07-30 22:50:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/414123006/1
6 years, 4 months ago (2014-07-30 22:51:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-31 00:30:52 UTC) #6
leviw_travelin_and_unemployed
Hooray! LGTM!
6 years, 4 months ago (2014-07-31 00:32:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 01:38:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19785)
6 years, 4 months ago (2014-07-31 01:38:17 UTC) #9
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-07-31 04:34:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/414123006/1
6 years, 4 months ago (2014-07-31 04:35:24 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-31 05:38:23 UTC) #12
commit-bot: I haz the power
Change committed as 179289
6 years, 4 months ago (2014-07-31 06:11:21 UTC) #13
alancutter (OOO until 2018)
6 years, 3 months ago (2014-09-23 10:35:49 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/598503002/ by alancutter@chromium.org.

The reason for reverting is: Reverting this change fixes stable blocking bug:
https://crbug.com/413553.

Powered by Google App Engine
This is Rietveld 408576698