Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 414123005: Move DesktopWindowTreeHostX11Test.Deactivate to interactive_ui_tests (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move DesktopWindowTreeHostX11Test.Deactivate to interactive_ui_tests Hopefully the move will make DesktopWindowTreeHostX11Test.Deactivate no longer flaky. Only a single window can be active at a time. I suspect that this test sometimes fails when run in parallel with other tests BUG=396491 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285834

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -50 lines) Patch
M build/filename_rules.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 2 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
pkotwicz
Elliot, PTAL
6 years, 5 months ago (2014-07-25 01:21:55 UTC) #1
Elliot Glaysher
lgtm
6 years, 5 months ago (2014-07-25 17:57:13 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-25 18:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/414123005/1
6 years, 5 months ago (2014-07-25 18:27:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 19:52:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 20:03:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/46845)
6 years, 5 months ago (2014-07-25 20:03:50 UTC) #7
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-07-26 20:10:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/414123005/1
6 years, 4 months ago (2014-07-26 20:11:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-26 21:18:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-26 21:37:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/112)
6 years, 4 months ago (2014-07-26 21:37:40 UTC) #12
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-07-27 00:27:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/414123005/20001
6 years, 4 months ago (2014-07-27 00:28:30 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-27 03:38:18 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-07-27 11:22:01 UTC) #16
Message was sent while issue was closed.
Change committed as 285834

Powered by Google App Engine
This is Rietveld 408576698