Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/dom_ui/new_tab_page_sync_handler.cc

Issue 414075: Revert 32754 - Remove old bookmark sync promo from new tab page.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/new_tab_page_sync_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/new_tab_page_sync_handler.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_page_sync_handler.cc (revision 32755)
+++ chrome/browser/dom_ui/new_tab_page_sync_handler.cc (working copy)
@@ -125,8 +125,15 @@
return;
}
- // Don't show sync status if setup is not complete.
+ // We show the sync promotion if sync has not been enabled and the user is
+ // logged in to Google Accounts. If the user is not signed in to GA, we
+ // should hide the sync status section entirely.
if (!sync_service_->HasSyncSetupCompleted()) {
+ if (!sync_service_->SetupInProgress() && IsGoogleGAIACookieInstalled()) {
+ SendSyncMessageToPage(PROMOTION,
+ WideToUTF8(l10n_util::GetString(IDS_SYNC_NTP_PROMOTION_MESSAGE)),
+ WideToUTF8(l10n_util::GetString(IDS_SYNC_NTP_START_NOW_LINK_LABEL)));
+ }
return;
}
@@ -175,6 +182,7 @@
std::string linkurl;
switch (type) {
case HIDE:
+ case PROMOTION:
msgtype = "presynced";
break;
case SYNC_ERROR:
« no previous file with comments | « chrome/browser/dom_ui/new_tab_page_sync_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698