sync: get rid of path_helpers

sync: get rid of path_helpers files.

Patch from Thiago Farina (thiago.farina@gmail.com)

BUG=26443
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33050

[tfarina (gmail-do not use), 2009-11-21 20:38:03]

Hi Tim, could you review this to me?

[tfarina (gmail-do not use), 2009-11-21 20:41:25]

Tim I looked into path_helpers_linux.cc, and path_helpers_mac.cc and in both
files there is no code, just 2 includes, we can remove these too?

[tim (not reviewing), 2009-11-21 20:42:49]

It looks like the function isn't used anywhere? Can we just remove all the
path_helper* files?

[tfarina (gmail-do not use), 2009-11-21 22:14:43]

On 2009/11/21 20:42:49, timsteele wrote:
> It looks like the function isn't used anywhere? Can we just remove all the
> path_helper* files?
Sorry for the delay, I will look right now.

[tfarina (gmail-do not use), 2009-11-21 23:05:52]

Tim, I will remove it, since it is used only in path_helpers_unittest.cc

[tfarina (gmail-do not use), 2009-11-21 23:26:25]

Please have another look.

[ncarter (slow), 2009-11-23 21:53:57]

On 2009/11/21 23:26:25, tfarina wrote:
> Please have another look.

Running this through the trybots now.

[ncarter (slow), 2009-11-23 22:30:13]

On 2009/11/23 21:53:57, nick wrote:
> On 2009/11/21 23:26:25, tfarina wrote:
> > Please have another look.
> 
> Running this through the trybots now.

Compile failed.  There are still some #includes that reference path_helpers.h
http://build.chromium.org/buildbot/try-server/builders/mac/builds/9473

[tfarina (gmail-do not use), 2009-11-23 23:59:49]

On 2009/11/23 22:30:13, nick wrote:
> On 2009/11/23 21:53:57, nick wrote:
> > On 2009/11/21 23:26:25, tfarina wrote:
> > > Please have another look.
> > 
> > Running this through the trybots now.
> 
> Compile failed.  There are still some #includes that reference path_helpers.h
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/9473

Thanks Nick, I fixed those failures, was my fault. But I will wait until munjal
commit his PathString change, because some #includes are in paths that I
modified in my PathString change.

Soon his commit, I will upload my change with the fixes.

[ncarter (slow), 2009-11-24 00:03:45]

Thanks, just let me know when I should have another look.

On Mon, Nov 23, 2009 at 3:59 PM, <thiago.farina@gmail.com> wrote:

> On 2009/11/23 22:30:13, nick wrote:
>
>> On 2009/11/23 21:53:57, nick wrote:
>> > On 2009/11/21 23:26:25, tfarina wrote:
>> > > Please have another look.
>> >
>> > Running this through the trybots now.
>>
>
>  Compile failed.  There are still some #includes that reference
>> path_helpers.h
>> http://build.chromium.org/buildbot/try-server/builders/mac/builds/9473
>>
>
> Thanks Nick, I fixed those failures, was my fault. But I will wait until
> munjal
> commit his PathString change, because some #includes are in paths that I
> modified in my PathString change.
>
> Soon his commit, I will upload my change with the fixes.
>
>
>
> http://codereview.chromium.org/414072
>

[tfarina (gmail-do not use), 2009-11-24 01:56:06]

On 2009/11/24 00:03:45, nick wrote:
> Thanks, just let me know when I should have another look.

Nick, I saw that munjal already committed his PathString change, so I updated
mine. Please take look.

[ncarter (slow), 2009-11-25 01:40:30]

On 2009/11/24 01:56:06, tfarina wrote:
> On 2009/11/24 00:03:45, nick wrote:
> > Thanks, just let me know when I should have another look.
> 
> Nick, I saw that munjal already committed his PathString change, so I updated
> mine. Please take look.

Looks good.  Running through the trybots and will submit if it's green.

[tfarina (gmail-do not use), 2009-11-25 02:31:13]

On 2009/11/25 01:40:30, nick wrote:
> On 2009/11/24 01:56:06, tfarina wrote:
> > On 2009/11/24 00:03:45, nick wrote:
> > > Thanks, just let me know when I should have another look.
> > 
> > Nick, I saw that munjal already committed his PathString change, so I
updated
> > mine. Please take look.
> 
> Looks good.  Running through the trybots and will submit if it's green.

Nick, I looked at the failures, the trybots were trying to compile
path_helpers_unittest.cc, because I forgot to remove the entry from chrome.gyp.
I uploaded the fix.

[ncarter (slow), 2009-11-25 02:35:02]

On 2009/11/25 02:31:13, tfarina wrote:
> On 2009/11/25 01:40:30, nick wrote:
> > On 2009/11/24 01:56:06, tfarina wrote:
> > > On 2009/11/24 00:03:45, nick wrote:
> > > > Thanks, just let me know when I should have another look.
> > > 
> > > Nick, I saw that munjal already committed his PathString change, so I
> updated
> > > mine. Please take look.
> > 
> > Looks good.  Running through the trybots and will submit if it's green.
> 
> Nick, I looked at the failures, the trybots were trying to compile
> path_helpers_unittest.cc, because I forgot to remove the entry from
chrome.gyp.
> I uploaded the fix.

Retrying now.

[tfarina (gmail-do not use), 2009-11-25 15:08:27]

Thanks Nick.