Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 414028: Mac: remove cursor turd from About dialog. (Closed)

Created:
11 years, 1 month ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai, TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: remove cursor turd from About dialog. (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32598

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment. #

Patch Set 3 : Merged ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -645 lines) Patch
M chrome/app/nibs/About.xib View 36 chunks +96 lines, -644 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/cocoa/about_window_controller.mm View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
11 years, 1 month ago (2009-11-20 03:51:28 UTC) #1
Mark Mentovai
LGTM http://codereview.chromium.org/414028/diff/1/4 File chrome/browser/cocoa/about_window_controller.mm (right): http://codereview.chromium.org/414028/diff/1/4#newcode80 Line 80: // We never want to draw the ...
11 years, 1 month ago (2009-11-20 04:34:40 UTC) #2
viettrungluu
Thanks, Mark. http://codereview.chromium.org/414028/diff/1/4 File chrome/browser/cocoa/about_window_controller.mm (right): http://codereview.chromium.org/414028/diff/1/4#newcode80 Line 80: // We never want to draw ...
11 years, 1 month ago (2009-11-20 04:46:56 UTC) #3
Mark Mentovai
LGTM
11 years, 1 month ago (2009-11-20 05:03:22 UTC) #4
TVL
lg If we can suppress selection, we should make this a generic class so infobars ...
11 years, 1 month ago (2009-11-20 05:37:51 UTC) #5
viettrungluu
On 2009/11/20 05:37:51, TVL wrote: > lg > > If we can suppress selection, we ...
11 years, 1 month ago (2009-11-20 16:14:56 UTC) #6
TVL
11 years, 1 month ago (2009-11-20 16:16:32 UTC) #7
On Fri, Nov 20, 2009 at 11:14 AM, <viettrungluu@chromium.org> wrote:

> On 2009/11/20 05:37:51, TVL wrote:
>
>> lg
>>
>
>  If we can suppress selection, we should make this a generic class so
>> infobars
>> can also use it.
>>
>
> Do we want to suppress selection? I know that Apple does so for their About
> dialogs, but it annoys me when I can't copy text from a dialog box (because
> then
> I usually end up retyping it, which is just dumb).
>
>
We need this sorta behavior in a few places, and it doesn't always make
sense to support selection (infobars, etc.)

TVL


>
> http://codereview.chromium.org/414028
>

Powered by Google App Engine
This is Rietveld 408576698