Mac: remove cursor turd from About dialog.

Mac: remove cursor turd from About dialog.

(The cursor was displayed with full keyboard accessibility enabled.)

Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|).

BUG=25570
TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32598

[Mark Mentovai, 2009-11-20 04:34:40]

LGTM

http://codereview.chromium.org/414028/diff/1/4
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/414028/diff/1/4#newcode80
Line 80: // We never want to draw the insertion point (otherwise, it shows up
without any
Revise comment to eliminate "we."

This sentence would be fine if it said "Never draw the insertion…".

[viettrungluu, 2009-11-20 04:46:56]

Thanks, Mark.

http://codereview.chromium.org/414028/diff/1/4
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/414028/diff/1/4#newcode80
Line 80: // We never want to draw the insertion point (otherwise, it shows up
without any
On 2009/11/20 04:34:40, Mark Mentovai wrote:
> Revise comment to eliminate "we."
> 
> This sentence would be fine if it said "Never draw the insertion…".

Done.

[Mark Mentovai, 2009-11-20 05:03:22]

LGTM

[TVL, 2009-11-20 05:37:51]

lg

If we can suppress selection, we should make this a generic class so infobars
can also use it.

[viettrungluu, 2009-11-20 16:14:56]

On 2009/11/20 05:37:51, TVL wrote:
> lg
> 
> If we can suppress selection, we should make this a generic class so infobars
> can also use it.

Do we want to suppress selection? I know that Apple does so for their About
dialogs, but it annoys me when I can't copy text from a dialog box (because then
I usually end up retyping it, which is just dumb).

[TVL, 2009-11-20 16:16:32]

On Fri, Nov 20, 2009 at 11:14 AM, <viettrungluu@chromium.org> wrote:

> On 2009/11/20 05:37:51, TVL wrote:
>
>> lg
>>
>
>  If we can suppress selection, we should make this a generic class so
>> infobars
>> can also use it.
>>
>
> Do we want to suppress selection? I know that Apple does so for their About
> dialogs, but it annoys me when I can't copy text from a dialog box (because
> then
> I usually end up retyping it, which is just dumb).
>
>
We need this sorta behavior in a few places, and it doesn't always make
sense to support selection (infobars, etc.)

TVL


>
> http://codereview.chromium.org/414028
>