Source/core/inspector/InspectorConsoleAgent.cpp - Issue 414013002: DevTools: nits: collect only top call frame in InspectorConsoleAgent::consoleCount.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorConsoleAgent.cpp

Issue 414013002: DevTools: nits: collect only top call frame in InspectorConsoleAgent::consoleCount. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorConsoleAgent.cpp

diff --git a/Source/core/inspector/InspectorConsoleAgent.cpp b/Source/core/inspector/InspectorConsoleAgent.cpp

index e530edd3d1c7458d3ee0f068c1d7ca7c72fab4f4..a2b042b1cd537c69cbb846afbf645c6b6c8efc1d 100644

--- a/Source/core/inspector/InspectorConsoleAgent.cpp

+++ b/Source/core/inspector/InspectorConsoleAgent.cpp

@@ -234,7 +234,7 @@ void InspectorConsoleAgent::consoleTimelineEnd(ExecutionContext* context, const

void InspectorConsoleAgent::consoleCount(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> arguments)

{

- RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(scriptState));

+ RefPtrWillBeRawPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(scriptState, 1));

const ScriptCallFrame& lastCaller = callStack->at(0);

// Follow Firebug's behavior of counting with null and undefined title in

// the same bucket as no argument

« no previous file with comments | « no previous file | no next file » | no next file with comments »