Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: Source/web/WebLeakDetector.cpp

Issue 413993002: LeakDetector: Terminate all WebEmbeddedWorkerImpl before counting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebLeakDetector.cpp
diff --git a/Source/web/WebLeakDetector.cpp b/Source/web/WebLeakDetector.cpp
index 3cd2d162d7ca933948fef8d5b2e27c0007a82dea..21323e4c42451fe8ba111b0d6d9fb9145aac96bc 100644
--- a/Source/web/WebLeakDetector.cpp
+++ b/Source/web/WebLeakDetector.cpp
@@ -41,6 +41,7 @@
#include "platform/Timer.h"
#include "public/web/WebDocument.h"
#include "public/web/WebLocalFrame.h"
+#include "web/WebEmbeddedWorkerImpl.h"
#include <v8.h>
@@ -82,6 +83,7 @@ private:
void WebLeakDetectorImpl::collectGarbageAndGetDOMCounts(WebLocalFrame* frame)
{
+ WebEmbeddedWorkerImpl::terminateAll();
michaeln 2014/07/25 00:07:09 i think it will take some time to unwind the backg
kouhei (in TOK) 2014/07/25 01:33:09 LeakDetector already flushes the task queue 2 time
michaeln 2014/07/25 02:49:52 i doubt if the collection of running instances is
kouhei (in TOK) 2014/07/25 05:00:39 Yes I confirmed that there are no false positive l
memoryCache()->evictResources();
{
« Source/web/WebEmbeddedWorkerImpl.cpp ('K') | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698