Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 413983005: Remove unnecesssary auxiliary definitions. (Closed)

Created:
6 years, 5 months ago by neis
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove unnecesssary auxiliary definitions. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22860

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -57 lines) Patch
M src/types.cc View 1 5 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/test-types.cc View 1 9 chunks +6 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
neis
6 years, 5 months ago (2014-07-24 08:42:13 UTC) #1
rossberg
https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (left): https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc#oldcode366 test/cctest/test-types.cc:366: Rep::IsClass(type1) == Rep::IsClass(type2) && I don't think these should ...
6 years, 5 months ago (2014-07-24 09:38:30 UTC) #2
rossberg
lgtm
6 years, 4 months ago (2014-08-05 11:26:10 UTC) #3
neis
6 years, 4 months ago (2014-08-05 11:27:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698