Refactor infra git libs and testing.

infra/libs/git2/data/commit.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import collections
 import hashlib
 import logging
 import re
 
 from cStringIO import StringIO
 
-from infra.services.gnumbd.support.util import cached_property, freeze
+from infra.libs.decorators import cached_property
+from infra.libs.infra_types import freeze
+
+from infra.libs.git2.data.data import Alterable
 
 LOGGER = logging.getLogger(__name__)
 
+
 ################################################################################
 # Exceptions
 ################################################################################
 
 class PartialCommit(Exception):
   def __init__(self, hsh, raw):
     super(PartialCommit, self).__init__(
         'Commit %s has partial content: %r' % (hsh, raw))
     self.raw = raw
 
 
 class UnexpectedHeader(Exception):
   def __init__(self, hsh, header, value):
     super(UnexpectedHeader, self).__init__(
         'Unexpected header in commit %s: %r -> %r' % (hsh, header, value))
 
 
 ################################################################################
-# Base Class
-################################################################################
-
-class Alterable(object):
-  def to_dict(self):  # pragma: no cover
-    """The shallow dictionary representation of this object (i.e. the dictionary
-    may contain Alterable instances as values)."""
-    raise NotImplementedError()
-
-  def alter(self, **kwargs):  # pragma: no cover
-    """Returns a copy of self, except with the fields listed in kwargs replaced
-    with new values."""
-    raise NotImplementedError()
-
-  @classmethod
-  def from_raw(cls, data):  # pragma: no cover
-    """Construct an instance of this class from a string."""
-    raise NotImplementedError()
-
-
-################################################################################
 # Implementation
 ################################################################################
 
 class CommitTimestamp(Alterable):
   def __init__(self, secs, sign, hours, mins):
     super(CommitTimestamp, self).__init__()
     assert isinstance(secs, int)
     assert sign in '+-'
     assert 0 <= hours < 24
     assert 0 <= mins < 60
@@ skipping 381 matching lines @@
       LOGGER.warn('Footers comprise entire message')
       message_lines = []
 
     footer_lines.reverse()
 
     if not tree or set(('author', 'committer')).difference(users.keys()):
       raise PartialCommit(hsh_fn(), data)
 
     return cls(tree, parents, users['author'], users['committer'],
                other_header_lines, message_lines, footer_lines)