Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 413913002: Disable flaky tests related to "Cannot read property 'textdirection' of undefined" (Closed)

Created:
6 years, 5 months ago by stgao
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable flaky tests related to "Cannot read property 'textdirection' of undefined". BUG=396752 R=kalman@chromium.org TBR=ben@chromium.org, dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285100

Patch Set 1 #

Patch Set 2 : Disable more tests. #

Patch Set 3 : Fix nit #

Total comments: 2

Patch Set 4 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_browsertest.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
lgtm, but there are more tests to disable if you look at the various logs ...
6 years, 5 months ago (2014-07-24 00:31:07 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/413913002/diff/40001/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc File chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (right): https://codereview.chromium.org/413913002/diff/40001/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc#newcode294 chrome/browser/ui/find_bar/find_bar_host_browsertest.cc:294: // Disabled due to crbug.com/175711 and crbug.com/396752. you ...
6 years, 5 months ago (2014-07-24 01:02:21 UTC) #2
stgao
https://codereview.chromium.org/413913002/diff/40001/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc File chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (right): https://codereview.chromium.org/413913002/diff/40001/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc#newcode294 chrome/browser/ui/find_bar/find_bar_host_browsertest.cc:294: // Disabled due to crbug.com/175711 and crbug.com/396752. On 2014/07/24 ...
6 years, 5 months ago (2014-07-24 01:04:33 UTC) #3
stgao
Committed patchset #4 manually as r285100 (presubmit successful).
6 years, 5 months ago (2014-07-24 01:05:06 UTC) #4
engedy
6 years, 4 months ago (2014-07-28 11:18:48 UTC) #5
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/422853004/ by engedy@chromium.org.

The reason for reverting is: The flakes seem to have been caused by
http://src.chromium.org/viewvc/blink?revision=178571&view=revision, which have
been since reverted in https://codereview.chromium.org/418783002/ and rolled to
Chromium in https://codereview.chromium.org/418713003.

The errors can no longer be reproduced with ToT..

Powered by Google App Engine
This is Rietveld 408576698