Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: Source/core/rendering/HitTestResult.h

Issue 413903004: Oilpan: Change Persistent<> data members to Member<> in HitTestResult. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/HitTestResult.h
diff --git a/Source/core/rendering/HitTestResult.h b/Source/core/rendering/HitTestResult.h
index f930f86903c2a56ba6579ee8e4fbd6dab6d34c33..84e50f9a3ca8f3d697eadd432780a16b62701f1f 100644
--- a/Source/core/rendering/HitTestResult.h
+++ b/Source/core/rendering/HitTestResult.h
@@ -47,6 +47,7 @@ class PositionWithAffinity;
class Scrollbar;
class HitTestResult {
+ DISALLOW_ALLOCATION();
public:
typedef WillBeHeapListHashSet<RefPtrWillBeMember<Node> > NodeSet;
@@ -58,6 +59,7 @@ public:
HitTestResult(const HitTestResult&);
~HitTestResult();
HitTestResult& operator=(const HitTestResult&);
+ void trace(Visitor*);
Node* innerNode() const { return m_innerNode.get(); }
Node* innerPossiblyPseudoNode() const { return m_innerPossiblyPseudoNode.get(); }
@@ -135,19 +137,19 @@ private:
HitTestLocation m_hitTestLocation;
- RefPtrWillBePersistent<Node> m_innerNode;
- RefPtrWillBePersistent<Node> m_innerPossiblyPseudoNode;
- RefPtrWillBePersistent<Node> m_innerNonSharedNode;
+ RefPtrWillBeMember<Node> m_innerNode;
+ RefPtrWillBeMember<Node> m_innerPossiblyPseudoNode;
+ RefPtrWillBeMember<Node> m_innerNonSharedNode;
// FIXME: Nothing changes this to a value different from m_hitTestLocation!
LayoutPoint m_pointInInnerNodeFrame; // The hit-tested point in innerNode frame coordinates.
LayoutPoint m_localPoint; // A point in the local coordinate space of m_innerNonSharedNode's renderer. Allows us to efficiently
// determine where inside the renderer we hit on subsequent operations.
- RefPtrWillBePersistent<Element> m_innerURLElement;
+ RefPtrWillBeMember<Element> m_innerURLElement;
RefPtr<Scrollbar> m_scrollbar;
bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a RenderWidget for example).
bool m_isFirstLetter;
- mutable OwnPtrWillBePersistent<NodeSet> m_rectBasedTestResult;
+ mutable OwnPtrWillBeMember<NodeSet> m_rectBasedTestResult;
};
} // namespace blink
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698