Oilpan: Change Persistent<> data members to Member<> in HitTestResult.

Oilpan: Change Persistent<> data members to Member<> in HitTestResult.

- Disallow new/delete operations for HitTestResult.
HitTestResult was used
-- with new/delete operators
-- as part objects of ContextMenuController and MouseEventWithHitTestResult.
-- as stack allocated objects

We'd like to avoid to make such classes in Oilpan.
So, this CL disallows new/delete, and WebHitTestResult owns another
class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
introduce new function to WebViewImpl for WebSubstringUtil.mm.

Difference from r176393:
Always calling HitTestResult member functions was bad. Some of them are
expensive. So WebHitTestResultPrivate contains a HitTestResult copy, and
WebHitTestResultPrivate is RefCountedWillBeGarbageCollectedFinalized in order to
trace HitTestResult.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178997

[tkent, 2014-07-24 06:58:51]

Please review this again.
Only WebHitTestResult.{h,cpp} have differences from the previous one
<https://codereview.chromium.org/326393003/>.

[haraken, 2014-07-24 07:13:47]

LGTM

[sof, 2014-07-24 07:18:14]

lgtm, this looks simpler&better than the previous approach.

https://codereview.chromium.org/413903004/diff/1/Source/web/WebHitTestResult.cpp
File Source/web/WebHitTestResult.cpp (right):

https://codereview.chromium.org/413903004/diff/1/Source/web/WebHitTestResult....
Source/web/WebHitTestResult.cpp:40: using namespace blink;
nit: can be removed.

https://codereview.chromium.org/413903004/diff/1/public/web/WebHitTestResult.h
File public/web/WebHitTestResult.h (right):

https://codereview.chromium.org/413903004/diff/1/public/web/WebHitTestResult....
public/web/WebHitTestResult.h:32: class HitTestResult;
This namespace block can be merged with the main one below.

[tkent, 2014-07-25 01:27:35]

+aelias@

[aelias_OOO_until_Jul13, 2014-07-25 19:08:42]

lgtm.  I cherry-picked locally and verified the perf regression didn't return.

[tkent, 2014-07-28 00:28:47]

On 2014/07/25 19:08:42, aelias wrote:
> lgtm.  I cherry-picked locally and verified the perf regression didn't return.

Cool.  Thank you!

[tkent, 2014-07-28 00:28:53]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-28 00:30:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/413903004/1

[commit-bot: I haz the power, 2014-07-28 00:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 00:30:19]

Failed to apply patch for Source/core/page/Page.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/Page.cpp
  Hunk #1 FAILED at 601.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/page/Page.cpp.rej

Patch:       Source/core/page/Page.cpp
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index
0a2bf30bfe08656d409987d199e24ed566d52a2e..aa9179a52a96f21a46d14b9adf6379104038ac18
100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -601,6 +601,7 @@ void Page::trace(Visitor* visitor)
 #if ENABLE(OILPAN)
     visitor->trace(m_dragCaretController);
     visitor->trace(m_dragController);
+    visitor->trace(m_contextMenuController);
     visitor->trace(m_pointerLockController);
     visitor->trace(m_undoStack);
     visitor->trace(m_validationMessageClient);

[tkent, 2014-07-28 01:00:34]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-28 01:01:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/413903004/20001

[commit-bot: I haz the power, 2014-07-28 02:05:09]

Change committed as 178997