Issue 413863002: Add breakpad component to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413863002: Add breakpad component to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add breakpad component to GN build. Comment the breakpad gyp file. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285055

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -27 lines)			Patch
M	breakpad/BUILD.gn	View	12 chunks	+16 lines, -15 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	18 chunks	+18 lines, -0 lines	0 comments	Download
M	components/BUILD.gn	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	components/breakpad.gypi	View	4 chunks	+5 lines, -0 lines	0 comments	Download
A	components/breakpad/app/BUILD.gn	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A	components/breakpad/browser/BUILD.gn	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A +	components/breakpad/tools/BUILD.gn	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	content/shell/BUILD.gn	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

brettw

This should fix the breakpad include dirs on Linux, at least.

6 years, 5 months ago (2014-07-23 21:13:51 UTC) #1

brettw

This should fix the breakpad include dirs on Linux, at least.

6 years, 5 months ago (2014-07-23 21:13:52 UTC) #2

jamesr

typo 'compoent' -> 'component' lgtm i'll try this on mac later

6 years, 5 months ago (2014-07-23 21:15:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r285055.