Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 413823002: Cache gfx::RenderText instances in views::Label. (Closed)

Created:
6 years, 5 months ago by msw
Modified:
5 years, 10 months ago
Reviewers:
ckocagil
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, vadimt
Visibility:
Public.

Description

[ REVIVED AS https://codereview.chromium.org/867003002/ ] Cache gfx::RenderText instances in views::Label. Cache RenderText instances, avoid Canvas::DrawString*. (avoids repeating itemization, layout, etc. on each paint) Recalculate colors and reset the layout as needed. Large cleanup; remove obsolete flag tests; update tests. Update App List's CachedLabel views::Label subclass use. (SchedulePaintInRect triggered paint with color changes) Ensure SetTitleSubpixelAA is otherwise called as needed. (skip early return; which breaks folder reorganization) BUG=240037, 125348 TEST=Improved Browser UI text rendering performance (especially for RTL tab title dragging), no appearance changes. R=sky@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -919 lines) Patch
M ui/app_list/views/app_list_item_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 7 chunks +6 lines, -10 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.h View 8 chunks +32 lines, -65 lines 0 comments Download
M ui/views/controls/label.cc View 11 chunks +175 lines, -296 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 3 chunks +5 lines, -546 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ckocagil
+vadimt: Perhaps this CL fixes the text rendering perf issues. http://crbug.com/431326
6 years ago (2014-12-16 15:37:15 UTC) #1
Daniel Erat
On 2014/12/16 15:37:15, ckocagil wrote: > +vadimt: Perhaps this CL fixes the text rendering perf ...
6 years ago (2014-12-16 15:52:52 UTC) #2
ckocagil
Without this patch, we're doing full RenderText shaping(s) for every |Label::OnPaint| for text eliding!! Mike, ...
5 years, 11 months ago (2015-01-07 14:09:04 UTC) #3
msw
On 2015/01/07 14:09:04, ckocagil wrote: > Without this patch, we're doing full RenderText shaping(s) for ...
5 years, 11 months ago (2015-01-07 17:20:26 UTC) #4
ckocagil
5 years, 10 months ago (2015-02-13 20:25:58 UTC) #5
This CL is revived as https://codereview.chromium.org/867003002/. This one can
be closed.

Powered by Google App Engine
This is Rietveld 408576698