clang/win: Fix most -Wwriteable-strings warnings.

net/proxy/proxy_config_service_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_win.h"
 
 #include "net/base/net_errors.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_config_service_common_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 TEST(ProxyConfigServiceWinTest, SetFromIEConfig) {
+  // Like WINHTTP_CURRENT_USER_IE_PROXY_CONFIG, but with const strings.
+  struct IEProxyConfig {
+    BOOL auto_detect;
+    const wchar_t* auto_config_url;
+    const wchar_t* proxy;
+    const wchar_t* proxy_bypass;;

[Reid Kleckner, 2014/07/23 22:02:15]

Double semi-colon?

[Nico, 2014/07/23 22:04:17]

Done, thanks.

+  };
   const struct {
     // Input.
-    WINHTTP_CURRENT_USER_IE_PROXY_CONFIG ie_config;
+    IEProxyConfig ie_config;
 
     // Expected outputs (fields of the ProxyConfig).
     bool auto_detect;
     GURL pac_url;
     ProxyRulesExpectation proxy_rules;
     const char* proxy_bypass_list;  // newline separated
   } tests[] = {
     // Auto detect.
     {
       { // Input.
@@ skipping 155 matching lines @@
       },
 
       // Expected result.
       true,                       // auto_detect
       GURL(),                     // pac_url
       ProxyRulesExpectation::EmptyWithBypass("foo.com,google.com"),
     },
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
+    WINHTTP_CURRENT_USER_IE_PROXY_CONFIG ie_config = {
+        tests[i].ie_config.auto_detect,
+        const_cast<wchar_t*>(tests[i].ie_config.auto_config_url),
+        const_cast<wchar_t*>(tests[i].ie_config.proxy),
+        const_cast<wchar_t*>(tests[i].ie_config.proxy_bypass)};
     ProxyConfig config;
-    ProxyConfigServiceWin::SetFromIEConfig(&config, tests[i].ie_config);
+    ProxyConfigServiceWin::SetFromIEConfig(&config, ie_config);
 
     EXPECT_EQ(tests[i].auto_detect, config.auto_detect());
     EXPECT_EQ(tests[i].pac_url, config.pac_url());
     EXPECT_TRUE(tests[i].proxy_rules.Matches(config.proxy_rules()));
     EXPECT_EQ(PROXY_CONFIG_SOURCE_SYSTEM, config.source());
   }
 }
 
 }  // namespace net