Use heap iterator in store buffer when page was swept precisely.

Use heap iterator in store buffer when page was swept precisely.

BUG=
R=rmcilroy@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22592

Committed: https://code.google.com/p/v8/source/detail?r=22597

[Hannes Payer (out of office), 2014-07-23 10:44:01]

Hi Ross, this should fix the constant pool issue.

[rmcilroy, 2014-07-23 11:04:53]

https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h#newcode1495
src/objects-inl.h:1495: if (type == CONSTANT_POOL_ARRAY_TYPE) return false;
The constant pool array does contain pointers (in the "HEAP_PTR" part).  I'm
guessing this is OK for IteratePointersToNewSpace since it will never contain
pointers to the new space. but the function name is a bit confusing  - maybe
call it something like HeapObject::MayContainNewSpacePointers()?

[Hannes Payer (out of office), 2014-07-24 08:52:38]

https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/413693002/diff/1/src/objects-inl.h#newcode1495
src/objects-inl.h:1495: if (type == CONSTANT_POOL_ARRAY_TYPE) return false;
On 2014/07/23 11:04:53, rmcilroy wrote:
> The constant pool array does contain pointers (in the "HEAP_PTR" part).  I'm
> guessing this is OK for IteratePointersToNewSpace since it will never contain
> pointers to the new space. but the function name is a bit confusing  - maybe
> call it something like HeapObject::MayContainNewSpacePointers()? 

Makes sense. Done.

[rmcilroy, 2014-07-24 10:24:48]

This CL does fix the ConstantPoolPreciseGC test.

lgtm, thanks!

https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1495: if (type == CONSTANT_POOL_ARRAY_TYPE) return false;
nit - add a comment here that the ConstantPoolArray contains heap pointers, but
not new space pointers.

https://codereview.chromium.org/413693002/diff/20001/src/store-buffer.cc
File src/store-buffer.cc (right):

https://codereview.chromium.org/413693002/diff/20001/src/store-buffer.cc#newc...
src/store-buffer.cc:525: // We iterate over objects that contain pointers only.
nit - new space pointers only.

[Hannes Payer (out of office), 2014-07-24 10:40:08]

https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/413693002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1495: if (type == CONSTANT_POOL_ARRAY_TYPE) return false;
On 2014/07/24 10:24:48, rmcilroy wrote:
> nit - add a comment here that the ConstantPoolArray contains heap pointers,
but
> not new space pointers. 

Done.

https://codereview.chromium.org/413693002/diff/20001/src/store-buffer.cc
File src/store-buffer.cc (right):

https://codereview.chromium.org/413693002/diff/20001/src/store-buffer.cc#newc...
src/store-buffer.cc:525: // We iterate over objects that contain pointers only.
On 2014/07/24 10:24:48, rmcilroy wrote:
> nit - new space pointers only.

Done.

[Hannes Payer (out of office), 2014-07-24 10:45:44]

Committed patchset #3 manually as r22592 (presubmit successful).

[rmcilroy, 2014-07-24 12:12:51]

Committed patchset #3 manually as r22597 (presubmit successful).