Issue 413683002: LocalWindow::printErrorMessage(): check if frame is available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413683002: LocalWindow::printErrorMessage(): check if frame is available. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
haraken, mkosiba (inactive)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

LocalWindow::printErrorMessage(): check if frame is available. If there's no frame, there's no console to add message to either. R=haraken@chromium.org BUG=376704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178779

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/document-navigation-error-no-crash.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/document-navigation-error-no-crash-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/LocalDOMWindow.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/413683002/1

6 years, 5 months ago (2014-07-23 15:00:19 UTC) #4

mkosiba (inactive)

6 years, 5 months ago (2014-07-23 20:39:10 UTC) #6

Message was sent while issue was closed.

ah thanks for fixing this. I had a patch here:
https://codereview.chromium.org/309063005/ but it sort of got stuck. It seems
like my fix is the opposite of yours, up to you if you want to change the code
or not.

Expand Messages | Collapse Messages