Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 413683002: LocalWindow::printErrorMessage(): check if frame is available. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

LocalWindow::printErrorMessage(): check if frame is available. If there's no frame, there's no console to add message to either. R=haraken@chromium.org BUG=376704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A LayoutTests/fast/dom/document-navigation-error-no-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/document-navigation-error-no-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-23 13:37:28 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-23 13:49:27 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-23 14:59:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/413683002/1
6 years, 5 months ago (2014-07-23 15:00:19 UTC) #4
commit-bot: I haz the power
Change committed as 178779
6 years, 5 months ago (2014-07-23 19:37:52 UTC) #5
mkosiba (inactive)
6 years, 5 months ago (2014-07-23 20:39:10 UTC) #6
Message was sent while issue was closed.
ah thanks for fixing this. I had a patch here:
https://codereview.chromium.org/309063005/ but it sort of got stuck. It seems
like my fix is the opposite of yours, up to you if you want to change the code
or not.

Powered by Google App Engine
This is Rietveld 408576698