Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 413633003: Mojo: Introduces mojo::EventType and mojo::EventFlags (Closed)

Created:
6 years, 5 months ago by Hajime Morrita
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Introduces mojo::EventType and mojo::EventFlags This change introduces EventType and EventFlags enum types which mirror ui::EventType and ui::EventFlags. With these, simple mouse/touch based Mojo apps no longer have to depend on the ui module. Note that this doesn't introduce any keycodes. It will need some non-trivial work which deserves its own CL. BUG=330467 R=beng@chromium.org, darin@chromium.org, viettrungluu@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285080

Patch Set 1 #

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -59 lines) Patch
M mojo/examples/embedded_app/embedded_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/blink_input_events_type_converters.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M mojo/services/public/cpp/input_events/input_events_type_converters.h View 1 chunk +7 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/input_events/lib/input_event_names.h View 1 chunk +46 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 3 chunks +105 lines, -24 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +66 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hajime Morrita
6 years, 5 months ago (2014-07-23 01:36:49 UTC) #1
darin (slow to review)
Ben should take a look. This seems like a good change to me.
6 years, 5 months ago (2014-07-23 04:04:33 UTC) #2
Ben Goodger (Google)
yeah lgtm.
6 years, 5 months ago (2014-07-23 16:23:44 UTC) #3
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 5 months ago (2014-07-23 17:34:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/413633003/20001
6 years, 5 months ago (2014-07-23 17:35:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 21:05:48 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 00:06:31 UTC) #7
Message was sent while issue was closed.
Change committed as 285080

Powered by Google App Engine
This is Rietveld 408576698