net/quic/quic_stream_factory.cc - Issue 413573003: Allow QuicConnection to own its QuicPacketWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.cc

Issue 413573003: Allow QuicConnection to own its QuicPacketWriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change_BBR_sender_71436337

Patch Set: minor cleanup Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_factory.cc

diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc

index c4586604e4471d1fca123f6f90b058c90b3534ea..6a03695fd5fed942211698c311554dc375334218 100644

--- a/net/quic/quic_stream_factory.cc

+++ b/net/quic/quic_stream_factory.cc

@@ -829,9 +829,13 @@ int QuicStreamFactory::CreateSession(

clock_.get(), random_generator_));

}

- QuicConnection* connection =

- new QuicConnection(connection_id, addr, helper_.get(), writer.get(),

- false, supported_versions_);

+ QuicConnection* connection = new QuicConnection(connection_id,

+ addr,

+ helper_.get(),

+ writer.get(),

+ false /* owns_writer */,

+ false /* is_server */,

+ supported_versions_);

writer->SetConnection(connection);

connection->set_max_packet_length(max_packet_length_);

« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »